Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernel modules needed by Calico #1817

Merged
merged 1 commit into from
Aug 12, 2017

Conversation

tmjd
Copy link
Contributor

@tmjd tmjd commented Aug 11, 2017

  • Enable ipset module CONFIG_IP_SET_HASH_NET
  • Enable ipip module CONFIG_NET_IPIP

Fixes #1779
Addresses projectcalico/calico#1013

I've built the minikube.iso with make out/minikube.iso and was able to do minikube start --network-plugin cni --host-only-cidr 172.17.17.1/24 --iso-url file://$(pwd)/out/minikube.iso and was then able to deploy calico successfully to the resulting K8s cluster.

- Enable ipset module CONFIG_IP_SET_HASH_NET
- Enable ipip module CONFIG_NET_IPIP
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #1817 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1817      +/-   ##
==========================================
+ Coverage   36.25%   36.27%   +0.02%     
==========================================
  Files          51       51              
  Lines        3462     3462              
==========================================
+ Hits         1255     1256       +1     
+ Misses       2024     2023       -1     
  Partials      183      183
Impacted Files Coverage Δ
pkg/util/kubeconfig/config.go 47.61% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02400c1...e9394c8. Read the comment docs.

@aaron-prindle
Copy link
Contributor

@minikube-bot ok to test

@dlorenc dlorenc merged commit 437fe66 into kubernetes:master Aug 12, 2017
@dlorenc
Copy link
Contributor

dlorenc commented Aug 12, 2017

Thanks!

@spuranam
Copy link

@dlorenc @tmjd @aaron-prindle Was wondering if new version minikube.iso is available to download that includes this change?

@erasmus74
Copy link

@spuranam go enjoy your weekend! We can deal with this one monday! -Ed

@dlorenc
Copy link
Contributor

dlorenc commented Aug 12, 2017

@spuranam It should be available in our CI build bucket at:

gs://minikube-builds/1817/minikube.iso

Or: https://storage.googleapis.com/minikube-builds/1817/minikube.iso

@dlorenc
Copy link
Contributor

dlorenc commented Aug 12, 2017

But yeah, go enjoy your weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants