Use kubenet, add ebtables support #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
aaron-prindle
previously approved these changes
Jul 18, 2017
aaron-prindle
dismissed
their stale review
kubenet change might require additional changes
Codecov Report
@@ Coverage Diff @@
## master #1713 +/- ##
==========================================
+ Coverage 35.93% 35.94% +0.01%
==========================================
Files 51 51
Lines 3337 3338 +1
==========================================
+ Hits 1199 1200 +1
Misses 1958 1958
Partials 180 180
Continue to review full report at Codecov.
|
|
@minikube-bot test this please |
|
This LGTM |
dlorenc
approved these changes
Jul 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1568
kubenet requires ebtables, so i enabled the kernel module and added the binary. kubenet will create its own bridge,
cbr0and set that to promiscuous mode, fixing #1568