added AskForPasswordValue and 2 tests #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1708 +/- ##
=======================================
Coverage 35.95% 35.95%
=======================================
Files 51 51
Lines 3332 3332
=======================================
Hits 1198 1198
Misses 1954 1954
Partials 180 180Continue to review full report at Codecov.
|
|
@minikube-bot ok to test |
|
Can one of the admins verify this patch? |
|
@minikube-bot retest this please |
1 similar comment
|
@minikube-bot retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, this is to address #1608
Sorry if there's some sort assignment for issues (implicit or otherwise that I missed). Thought I'd give contributing a try regardless.
Any feedback welcome.