remove ssh-add flag and fix calling appendKnownHelper when not needed

[ComradeProgrammer]

Related #16933 #15452

1. appendKnownHelper should only be called when sshHost is true. appendKnownHelper should not be run when user is trying to connect to minikube's docker daemon with HTTP
2. before feat: direct image build on containerd via docker-env #15452 , to run minikube docker-env with ssh connection, user have to manually start a ssh-agent, and use ssh-add flag. But in feat: direct image build on containerd via docker-env #15452 , we added a feature, which automatically help users to do these two things, and user don't need to specify ssh-add or start a ssh-agent. However, no automation for "docker runtime with ssh connection". This makes docker-env's behavior inconsistent
3. so I think perhaps we should add this automation for "docker runtime with ssh connection" too. And if so, we no longer need ssh-add flag. As long as ssh-host is set, we will automatically do all these things for the user(start ssh-agent, run ssh-add). Continuing to use ssh-add flag will make things confusing.

@spowelljr @medyagh

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ComradeProgrammer
Once this PR has been reviewed and has the lgtm label, please assign afbjorklund for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @ComradeProgrammer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

lets keep things backward campatible

[medyagh]

lets go with most backward compatible approach

[ComradeProgrammer]

@medyagh The comments have been solved. Maybe you can have a look at it now?

[medyagh]

@afbjorklund whats your opinion on this PR

[afbjorklund]

Some typos.

Not sure it actually has to be deprecated, if it is truly not needed anymore than maybe it should just be removed from the documentation and made it into a no-op instead.

[afbjorklund]

But I never understood why we have to start a second ssh-agent anyway, usually it is started when you log in.

• feat: direct image build on containerd via docker-env #15452

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[ComradeProgrammer]

/remove-lifecycle stale