Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ipset (hash:ip and list:set) #1697

Merged
merged 1 commit into from
Jul 14, 2017
Merged

Enable ipset (hash:ip and list:set) #1697

merged 1 commit into from
Jul 14, 2017

Conversation

marccarre
Copy link
Contributor

Weave Net requires the xt_set module to function properly.
Minikube's Linux image currently does not have it, making Weave Net fail with errors like:

  • modprobe: FATAL: Module xt_set not found in directory /lib/modules/4.9.13
  • FATA: ipset [create weave-local-pods hash:ip] failed: ipset v6.29: Kernel error received: set type not supported: exit status 1

This changes addresses such issues and fixes weaveworks/weave/issues/3062.

Weave Net, a container networking solution, requires the `xt_set` module in order to function properly.
Minikube's Linux image currently does not have it, making Weave Net fail with errors like:

- `modprobe: FATAL: Module xt_set not found in directory /lib/modules/4.9.13`
- `FATA: ipset [create weave-local-pods hash:ip] failed: ipset v6.29: Kernel error received: set type not supported: exit status 1`

This changes addresses such issues.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 14, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #1697 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1697   +/-   ##
======================================
  Coverage    38.7%   38.7%           
======================================
  Files          51      51           
  Lines        2664    2664           
======================================
  Hits         1031    1031           
  Misses       1453    1453           
  Partials      180     180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c20965...74c09aa. Read the comment docs.

@dlorenc
Copy link
Contributor

dlorenc commented Jul 14, 2017

@minikube-bot ok to test

Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@r2d4 r2d4 merged commit ba0411b into kubernetes:master Jul 14, 2017
@marccarre
Copy link
Contributor Author

As mentioned by @r2d4 on Slack, and in case someone faces the same issue with xt_set and Weave Net, the ISO containing the fix is available here. The below commands may also be useful:

$ minikube start --iso-url https://storage.googleapis.com/minikube-builds/1697/minikube-testing.iso
$ minikube config set iso-url https://storage.googleapis.com/minikube-builds/1697/minikube-testing.iso

@erasmus74
Copy link

This issue still persists. Please reopen.

The ISO containing the fix is also bugged as it does not include the ipset module.

@sands6
Copy link

sands6 commented Aug 3, 2017

I concur. Please reopen.

The ISO does not contain ipset or xt_set modules.

@dlorenc
Copy link
Contributor

dlorenc commented Aug 3, 2017

This issue still persists. Please reopen.

This is a PR so we can't just reopen it, is there an issue tracking the missing modules? Could you open one if not?

@sands6
Copy link

sands6 commented Aug 3, 2017

#1779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure weave in minikube+kubernetes
8 participants