Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fetch localkube when version specified is default #1688

Merged
merged 1 commit into from
Jul 13, 2017

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Jul 12, 2017

Instead, use the binary that is already bundled with go-bindata.

ref #1687

Instead, use the binary that is already bundled with go-bindata.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2017
@codecov-io
Copy link

Codecov Report

Merging #1688 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1688      +/-   ##
==========================================
- Coverage   38.77%   38.73%   -0.04%     
==========================================
  Files          51       51              
  Lines        2664     2664              
==========================================
- Hits         1033     1032       -1     
  Misses       1452     1452              
- Partials      179      180       +1
Impacted Files Coverage Δ
pkg/minikube/cluster/cluster.go 44.54% <100%> (ø) ⬆️
pkg/util/kubeconfig/config.go 51.4% <0%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5972f...5271dd1. Read the comment docs.

@medyagh
Copy link
Member

medyagh commented Jul 13, 2017

thanks looks good

@r2d4 r2d4 merged commit e550e3d into kubernetes:master Jul 13, 2017
@r2d4 r2d4 deleted the local-localkube branch July 13, 2017 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants