Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Docker to 1.12.6. #1658

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Upgrade Docker to 1.12.6. #1658

merged 1 commit into from
Jun 29, 2017

Conversation

jgoclawski
Copy link
Contributor

Fixes #1439 and #1518.

Based on #1542, but without forwarding issues, as those changes are introduced in Docker 1.13+.
We've tested #1542 to use overlay2 instead of overlay (#1380) and we're seeing great performance and stability improvements.

Can one of the admins trigger the ISO build, please? We'd love to test it internally, play around and give feedback.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #1658 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1658   +/-   ##
=======================================
  Coverage   38.65%   38.65%           
=======================================
  Files          51       51           
  Lines        2667     2667           
=======================================
  Hits         1031     1031           
  Misses       1455     1455           
  Partials      181      181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f8f08...f711504. Read the comment docs.

@dlorenc
Copy link
Contributor

dlorenc commented Jun 28, 2017

@minikube-bot ok to test

@jgoclawski
Copy link
Contributor Author

Thanks for running the tests. It seems that all that should work have passed :)

If anyone wants to try the upgraded Docker 1.12, here is the command:
minikube start --iso-url https://storage.googleapis.com/minikube-builds/1658/minikube-testing.iso

I'm running this with storage driver changed from default overlay to overlay2:
minikube start --iso-url https://storage.googleapis.com/minikube-builds/1658/minikube-testing.iso --docker-opt storage-driver=overlay2

So far, so good, I haven't noticed any problems.

@dlorenc
Copy link
Contributor

dlorenc commented Jun 29, 2017

I think we should go ahead and take this. Thanks @jgoclawski!

@dlorenc dlorenc merged commit 4c624c2 into kubernetes:master Jun 29, 2017
@jgoclawski jgoclawski deleted the docker1.12 branch June 29, 2017 19:38
@jgoclawski
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants