-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable virtualbox host mounting by default #1646
Conversation
You had mentioned minishift supported passing flags/env vars to the driver. There seems to be one for the mount: |
Looks like theres a config option for that now, I'll update this PR to just set it |
Codecov Report
@@ Coverage Diff @@
## master #1646 +/- ##
==========================================
+ Coverage 38.65% 38.68% +0.03%
==========================================
Files 51 51
Lines 2667 2670 +3
==========================================
+ Hits 1031 1033 +2
- Misses 1455 1456 +1
Partials 181 181
Continue to review full report at Codecov.
|
Could we make this a flag? I think probably more users depend on this than we expect, and the mount command isn't quite ready to take over everything yet. |
Allows users to disable the filesystem mounts created by the xhyve and virtualbox drivers.
I added a new flag which toggles the driver specific mounts for virtualbox and xhyve. |
Users can still set up manual mounts through vbox using the vboxmanage
command or GUI. Users can also utilized the built in
minikube mount
command.
This is a bit of a hack, since the mounting is attempted in the driver, but it won't work without these extra steps in the image.
Fixes #1645