QEMU: add support for binfmt emulators

[michelesr]

Adds the missing kernel compilation flag CONFIG_BINFMT_MISC=y that is required by the Docker runtime to run images with emulated CPU architecture. See https://docs.docker.com/build/building/multi-platform for more information.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: michelesr / name: Michele Sorcinelli (9aaad84)

[k8s-ci-robot]

Welcome @michelesr!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @michelesr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[afbjorklund]

ok-to-build-image

/ok-to-test

[medyagh]

/ok-to-build-iso

[minikube-bot]

Hi @michelesr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16428) |
+----------------+----------+---------------------+
| minikube start | 51.1s    | 51.3s               |
| enable ingress | 27.0s    | 26.2s               |
+----------------+----------+---------------------+

Times for minikube start: 49.6s 52.6s 51.1s 51.2s 51.2s
Times for minikube (PR 16428) start: 48.7s 52.4s 51.8s 51.7s 51.9s

Times for minikube ingress: 27.1s 27.1s 27.1s 27.2s 26.6s
Times for minikube (PR 16428) ingress: 28.2s 27.7s 25.2s 25.2s 24.7s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 16428) |
+-------------------+----------+---------------------+
| minikube start    | 24.4s    | 23.0s               |
| ⚠️  enable ingress | 21.1s    | 26.7s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube (PR 16428) ingress: 49.5s 21.0s 20.0s 23.5s 19.5s
Times for minikube ingress: 20.9s 21.4s 20.9s 20.4s 21.8s

Times for minikube start: 24.8s 24.7s 24.9s 26.0s 21.8s
Times for minikube (PR 16428) start: 22.0s 22.3s 27.1s 21.6s 22.2s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16428) |
+----------------+----------+---------------------+
| minikube start | 23.8s    | 21.6s               |
| enable ingress | 28.9s    | 32.5s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 33.8s 21.2s 20.1s 21.0s
Times for minikube (PR 16428) start: 23.8s 21.0s 22.5s 20.7s 20.0s

Times for minikube ingress: 31.3s 31.3s 31.4s 19.3s 31.3s
Times for minikube (PR 16428) ingress: 32.6s 32.0s 33.0s 31.5s 33.5s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Hyperkit_macOS	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	0.00 (chart)
Hyperkit_macOS	TestNetworkPlugins/group/kindnet/Start (gopogh)	0.67 (chart)
Hyperkit_macOS	TestStartStop/group/newest-cni/serial/Pause (gopogh)	2.67 (chart)
Hyperkit_macOS	TestStartStop/group/newest-cni/serial/SecondStart (gopogh)	2.67 (chart)
Hyperkit_macOS	TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh)	2.67 (chart)
Docker_Windows	TestPause/serial/VerifyDeletedResources (gopogh)	7.58 (chart)
Docker_Windows	TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh)	8.57 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/Pause (gopogh)	9.52 (chart)
none_Linux	TestAddons/parallel/CSI (gopogh)	16.43 (chart)

To see the flake rates of all tests by environment, click here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michelesr

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[spowelljr]

That rebase didn't go good...

[spowelljr]

I don't have write access to https://github.com/michelesr/minikube/tree/master so I can't push his commit back onto his repo

commit 582472bbe86a71410d0291fcab4fd9ce792e2087 (HEAD -> michelesr/master)
Author: Michele Sorcinelli <michele.sorcinelli@citizensadvice.org.uk>
Date:   Mon Apr 17 13:19:02 2023 +0100

    Add CONFIG_BINFMT_MISC=y flag

Yet I was somehow able to blow away his commit without write access?

[michelesr]

yet I was somehow able to blow away his commit without write access?

@spowelljr not sure, but there's a setting that allows edits from maintainers and I suspect it might have been enabled before the PR was closed (it shows as disabled now but maybe it changed automatically after PR closure)

[spowelljr]

This change is merged via #16712