Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addons: Increase kubectl command timeout #16387

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Apr 27, 2023

Fixes #16391

Upped the kubectl timeout from 5 to 20 seconds.

minikube addons disable csi-hostpath-driver runs a kubectl command that takes 6 seconds on none driver, longer than our current timeout

W0427 04:42:26.122636   24793 addons.go:446] apply failed, will retry: sudo KUBECONFIG=/var/lib/minikube/kubeconfig /var/lib/minikube/binaries/v1.26.3/kubectl delete --ignore-not-found -f /etc/kubernetes/addons/rbac-external-attacher.yaml -f /etc/kubernetes/addons/rbac-hostpath.yaml -f /etc/kubernetes/addons/rbac-external-health-monitor-controller.yaml -f /etc/kubernetes/addons/rbac-external-provisioner.yaml -f /etc/kubernetes/addons/rbac-external-resizer.yaml -f /etc/kubernetes/addons/rbac-external-snapshotter.yaml -f /etc/kubernetes/addons/csi-hostpath-attacher.yaml -f /etc/kubernetes/addons/csi-hostpath-driverinfo.yaml -f /etc/kubernetes/addons/csi-hostpath-plugin.yaml -f /etc/kubernetes/addons/csi-hostpath-resizer.yaml -f /etc/kubernetes/addons/csi-hostpath-storageclass.yaml: signal: killed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 27, 2023
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 27, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 27, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16387) |
+----------------+----------+---------------------+
| minikube start | 50.5s    | 51.2s               |
| enable ingress | 27.2s    | 26.9s               |
+----------------+----------+---------------------+

Times for minikube start: 50.7s 48.3s 51.4s 50.7s 51.4s
Times for minikube (PR 16387) start: 50.4s 51.2s 51.0s 51.7s 51.9s

Times for minikube ingress: 29.2s 25.2s 25.7s 28.2s 27.8s
Times for minikube (PR 16387) ingress: 27.2s 29.8s 25.2s 24.7s 27.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16387) |
+----------------+----------+---------------------+
| minikube start | 22.9s    | 23.2s               |
| enable ingress | 22.1s    | 21.4s               |
+----------------+----------+---------------------+

Times for minikube start: 21.9s 21.1s 22.0s 24.7s 24.9s
Times for minikube (PR 16387) start: 21.7s 24.8s 21.8s 25.9s 21.7s

Times for minikube ingress: 22.5s 21.5s 22.5s 22.0s 22.0s
Times for minikube (PR 16387) ingress: 21.5s 20.5s 22.0s 21.0s 22.0s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 16387) |
+-------------------+----------+---------------------+
| minikube start    | 21.7s    | 21.1s               |
| ⚠️  enable ingress | 25.9s    | 33.3s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube (PR 16387) start: 20.4s 23.1s 20.4s 20.4s 21.0s
Times for minikube start: 23.3s 20.5s 20.6s 20.7s 23.4s

Times for minikube ingress: 21.5s 33.0s 32.0s 21.5s 21.5s
Times for minikube (PR 16387) ingress: 32.0s 33.0s 48.5s 20.5s 32.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestDockerFlags (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh) 1.28 (chart)
Hyperkit_macOS TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 1.28 (chart)
Hyperkit_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 1.28 (chart)
Hyperkit_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 1.92 (chart)
Hyperkit_macOS TestStartStop/group/newest-cni/serial/Pause (gopogh) 1.92 (chart)
Hyperkit_macOS TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 1.92 (chart)
Hyperkit_macOS TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh) 1.92 (chart)
Hyperkit_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 2.56 (chart)
Hyperkit_macOS TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 2.56 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 2.56 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) 3.27 (chart)
KVM_Linux TestMultiNode/serial/StartAfterStop (gopogh) 12.42 (chart)
Hyperkit_macOS TestRunningBinaryUpgrade (gopogh) 12.82 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr changed the title Increase kubectl command timeout addons: Increase kubectl command timeout Apr 27, 2023
@medyagh medyagh merged commit d9cd125 into kubernetes:master Apr 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr deleted the increaseKubectlTimeout branch April 28, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube addons disable csi-hostpath-driver failing on none driver
4 participants