Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change metallb image hosting from docker.io to quay.io #16055

Closed
wants to merge 1 commit into from

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Mar 15, 2023

because metallb/metallb#784

fixes #16053

before this PR

11:55:48 medya/workspace/minikube
metal_addon_image •1
$ kc get pods -A
NAMESPACE        NAME                               READY   STATUS         RESTARTS      AGE
kube-system      coredns-787d4945fb-tm2vs           1/1     Running        0             52s
kube-system      etcd-minikube                      1/1     Running        0             65s
kube-system      kube-apiserver-minikube            1/1     Running        0             65s
kube-system      kube-controller-manager-minikube   1/1     Running        0             65s
kube-system      kube-proxy-2swd8                   1/1     Running        0             52s
kube-system      kube-scheduler-minikube            1/1     Running        0             65s
kube-system      storage-provisioner                1/1     Running        1 (47s ago)   64s
metallb-system   controller-644c846477-2496w        0/1     ErrImagePull   0             3s
metallb-system   speaker-wvr8f                      0/1     ErrImagePull   0             3s

After this PR

$ kc get pods -A
NAMESPACE        NAME                               READY   STATUS    RESTARTS        AGE
kube-system      coredns-787d4945fb-zdg8v           1/1     Running   0               5m54s
kube-system      etcd-minikube                      1/1     Running   0               6m7s
kube-system      kube-apiserver-minikube            1/1     Running   0               6m7s
kube-system      kube-controller-manager-minikube   1/1     Running   0               6m7s
kube-system      kube-proxy-98cb6                   1/1     Running   0               5m54s
kube-system      kube-scheduler-minikube            1/1     Running   0               6m7s
kube-system      storage-provisioner                1/1     Running   1 (5m50s ago)   6m6s
metallb-system   controller-5bc6f8ffb-9v5k6         1/1     Running   0               9s
metallb-system   speaker-vhdh8                      1/1     Running   0               9s

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@medyagh
Copy link
Member Author

medyagh commented Mar 15, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 15, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16055) |
+----------------+----------+---------------------+
| minikube start | 53.9s    | 52.5s               |
| enable ingress | 26.5s    | 25.6s               |
+----------------+----------+---------------------+

Times for minikube start: 51.5s 51.2s 55.5s 54.6s 56.7s
Times for minikube (PR 16055) start: 53.9s 51.1s 51.0s 54.6s 51.7s

Times for minikube ingress: 24.2s 27.7s 27.7s 24.7s 28.2s
Times for minikube (PR 16055) ingress: 25.7s 27.7s 24.3s 25.2s 25.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16055) |
+----------------+----------+---------------------+
| minikube start | 26.8s    | 26.6s               |
| enable ingress | 21.8s    | 21.5s               |
+----------------+----------+---------------------+

Times for minikube start: 28.2s 26.4s 25.7s 26.6s 27.0s
Times for minikube (PR 16055) start: 25.6s 26.7s 26.3s 26.5s 27.8s

Times for minikube (PR 16055) ingress: 22.1s 22.1s 21.1s 21.1s 21.1s
Times for minikube ingress: 23.5s 20.1s 22.1s 21.1s 22.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16055) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 22.7s               |
| enable ingress | 35.0s    | 38.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 16055) start: 23.0s 23.2s 21.9s 23.4s 22.2s
Times for minikube start: 22.3s 22.4s 23.3s 22.5s 22.1s

Times for minikube (PR 16055) ingress: 48.6s 32.1s 47.0s 31.6s 31.6s
Times for minikube ingress: 47.5s 32.6s 31.6s 31.5s 31.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestFunctional/parallel/MountCmd/specific-port (gopogh) 1.20 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 100.00 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 100.00 (chart)
Docker_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh closed this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[addon] metallb image pull failure from docker.io
3 participants