Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QEMU: Rename user network to builtin and update documentation #15793

Merged
merged 4 commits into from
Feb 10, 2023

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Feb 6, 2023

Site:

  • Updated references from user to builtin
  • Added more information about the differences between the socket_vmnet and builtin network options
  • Added install/uninstall instructions for socket_vmnet via brew
  • Moved known issues into a tabbed component so user can see issues specific to their network option

QEMU:

  • Updated references from user to builtin
  • Still supports the user flag, but will rewrite the value to builtin on cluster creation

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 6, 2023
@spowelljr spowelljr marked this pull request as ready for review February 6, 2023 19:33
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2023
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets rename the "user" network name to "builtin" to confuse our "user"s (pun intended) less !
and still accept user as a legacy but not advertise it.

Above the Tabbed version of network isssues, we should call it Known Network issue
and we will have different block for Qemu core issues (not network)

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 9, 2023
pkg/network/network.go Outdated Show resolved Hide resolved
@spowelljr spowelljr changed the title site: improve QEMU documentation QEMU: Rename user network to builtin and update documentation Feb 9, 2023
@medyagh
Copy link
Member

medyagh commented Feb 10, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 10, 2023
@medyagh medyagh self-requested a review February 10, 2023 01:48
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15793) |
+----------------+----------+---------------------+
| minikube start | 53.4s    | 53.5s               |
| enable ingress | 25.4s    | 26.1s               |
+----------------+----------+---------------------+

Times for minikube start: 52.4s 53.0s 55.0s 52.7s 53.8s
Times for minikube (PR 15793) start: 55.6s 53.0s 52.7s 53.3s 52.9s

Times for minikube ingress: 27.7s 25.2s 24.7s 24.7s 24.7s
Times for minikube (PR 15793) ingress: 23.7s 27.2s 28.2s 27.7s 23.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15793) |
+----------------+----------+---------------------+
| minikube start | 26.5s    | 26.1s               |
| enable ingress | 33.5s    | 33.4s               |
+----------------+----------+---------------------+

Times for minikube start: 25.4s 26.8s 26.1s 27.3s 27.1s
Times for minikube (PR 15793) start: 25.7s 26.4s 26.0s 25.7s 26.7s

Times for minikube ingress: 21.1s 81.6s 21.1s 22.1s 21.5s
Times for minikube (PR 15793) ingress: 22.1s 20.0s 21.6s 21.0s 82.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15793) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 22.0s               |
| enable ingress | 38.7s    | 22.6s               |
+----------------+----------+---------------------+

Times for minikube start: 21.8s 21.6s 22.0s 22.2s 21.7s
Times for minikube (PR 15793) start: 21.4s 22.2s 22.2s 21.8s 22.2s

Times for minikube ingress: 31.6s 19.6s 79.5s 31.6s 31.5s
Times for minikube (PR 15793) ingress: 31.6s 20.6s 19.6s 19.5s 21.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/newest-cni/serial/Pause (gopogh) 0.69 (chart)
Hyperkit_macOS TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 0.69 (chart)
Hyperkit_macOS TestFunctional/parallel/ConfigCmd (gopogh) 1.38 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 3.12 (chart)
Hyperkit_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 9.72 (chart)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 10.62 (chart)
Hyperkit_macOS TestRunningBinaryUpgrade (gopogh) 11.72 (chart)
Hyper-V_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 40.58 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 50.00 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 52.86 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 98.04 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit fc644b8 into kubernetes:master Feb 10, 2023
@spowelljr spowelljr deleted the tabbedVView branch February 13, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants