-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QEMU: Rename user
network to builtin
and update documentation
#15793
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets rename the "user" network name to "builtin" to confuse our "user"s (pun intended) less !
and still accept user as a legacy but not advertise it.
Above the Tabbed version of network isssues, we should call it Known Network issue
and we will have different block for Qemu core issues (not network)
user
network to builtin
and update documentation
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 52.4s 53.0s 55.0s 52.7s 53.8s Times for minikube ingress: 27.7s 25.2s 24.7s 24.7s 24.7s docker driver with docker runtime
Times for minikube start: 25.4s 26.8s 26.1s 27.3s 27.1s Times for minikube ingress: 21.1s 81.6s 21.1s 22.1s 21.5s docker driver with containerd runtime
Times for minikube start: 21.8s 21.6s 22.0s 22.2s 21.7s Times for minikube ingress: 31.6s 19.6s 79.5s 31.6s 31.5s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
Site:
user
tobuiltin
socket_vmnet
andbuiltin
network optionssocket_vmnet
via brewQEMU:
user
tobuiltin
user
flag, but will rewrite the value tobuiltin
on cluster creation