Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build conntrack as part of the iso. #157

Merged
merged 2 commits into from
Jun 3, 2016
Merged

Build conntrack as part of the iso. #157

merged 2 commits into from
Jun 3, 2016

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Jun 2, 2016

cc @luxas
Closes #136

@luxas
Copy link
Member

luxas commented Jun 3, 2016

LGTM except for one nit: may you append the list for the docker container too?
You don't have to but it would be nice

@dlorenc
Copy link
Contributor Author

dlorenc commented Jun 3, 2016

Which list? Do you mean the deploy/docker/Dockerfile ?

@luxas
Copy link
Member

luxas commented Jun 3, 2016

Yes

On 03 Jun 2016, at 18:26, dlorenc notifications@github.com wrote:

Which list? Do you mean the deploy/docker/Dockerfile ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@dlorenc
Copy link
Contributor Author

dlorenc commented Jun 3, 2016

Done.

@luxas
Copy link
Member

luxas commented Jun 3, 2016

Thanks. LGTM
(Travis doesn't touch these files, so merging)

@luxas luxas merged commit dcc0b38 into kubernetes:master Jun 3, 2016
@dlorenc dlorenc deleted the conntrack branch June 3, 2016 15:49
@xieyanker xieyanker mentioned this pull request Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlorenc @luxas @googlebot