Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cloud-spanner-emulator from 1.4.8 to 1.4.9 #15667

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Update cloud-spanner-emulator from 1.4.8 to 1.4.9 #15667

merged 1 commit into from
Jan 19, 2023

Conversation

spowelljr
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 19, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2023
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 19, 2023
medyagh
medyagh reviewed Jan 19, 2023
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be automated in Github Action
maybe we could have a job called "Addon Updates"

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15667) |
+----------------+----------+---------------------+
| minikube start | 55.7s    | 54.2s               |
| enable ingress | 37.8s    | 26.1s               |
+----------------+----------+---------------------+

Times for minikube start: 55.2s 54.5s 55.5s 57.6s 55.5s
Times for minikube (PR 15667) start: 54.6s 53.4s 54.6s 55.0s 53.2s

Times for minikube (PR 15667) ingress: 25.2s 25.1s 25.7s 27.2s 27.1s
Times for minikube ingress: 27.7s 26.2s 83.2s 26.7s 25.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15667) |
+----------------+----------+---------------------+
| minikube start | 26.5s    | 25.4s               |
| enable ingress | 25.8s    | 26.6s               |
+----------------+----------+---------------------+

Times for minikube start: 28.1s 25.0s 25.4s 28.4s 25.4s
Times for minikube (PR 15667) start: 24.6s 26.3s 24.4s 25.6s 26.1s

Times for minikube ingress: 21.0s 20.4s 19.4s 19.4s 48.9s
Times for minikube (PR 15667) ingress: 21.0s 20.4s 21.5s 49.9s 20.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15667) |
+----------------+----------+---------------------+
| minikube start | 25.0s    | 24.3s               |
| enable ingress | 26.3s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 15667) start: 21.6s 33.0s 22.5s 22.2s 22.4s
Times for minikube start: 22.1s 21.7s 36.6s 23.1s 21.5s

Times for minikube ingress: 26.5s 26.5s 26.5s 25.9s 26.0s
Times for minikube (PR 15667) ingress: 26.4s 26.4s 26.4s 26.0s 26.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestFunctional/serial/ExtraConfig (gopogh) 0.00 (chart)
Docker_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 0.00 (chart)
Hyperkit_macOS TestForceSystemdFlag (gopogh) 0.70 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 6.90 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/DeployApp (gopogh) 11.61 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 11.61 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/FirstStart (gopogh) 12.39 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/SecondStart (gopogh) 13.91 (chart)
Docker_macOS TestStartStop/group/newest-cni/serial/Pause (gopogh) 22.22 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 25.76 (chart)
Docker_macOS TestMultiNode/serial/RestartMultiNode (gopogh) 31.25 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 41.96 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 41.96 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 42.48 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 42.98 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 50.89 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 50.89 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 52.17 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh) 52.17 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 66.67 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 66.67 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 78.45 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 79.21 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 81.51 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 82.18 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 84.16 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 86.14 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/HairPin (gopogh) 87.50 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/HairPin (gopogh) 90.48 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 96.97 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 8ffa1f9 into kubernetes:master Jan 19, 2023
@spowelljr spowelljr deleted the updateCloudSpanner branch January 19, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spowelljr @k8s-ci-robot @minikube-pr-bot @medyagh