Fixed mount daemon to be off by default and to use different director… #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
aaron-prindle
force-pushed
the
fix-mount
branch
3 times, most recently
from
f2915bc
to
6231443
Compare
Codecov Report
@@ Coverage Diff @@
## master #1511 +/- ##
==========================================
+ Coverage 40.41% 40.54% +0.12%
==========================================
Files 50 50
Lines 2479 2476 -3
==========================================
+ Hits 1002 1004 +2
+ Misses 1314 1310 -4
+ Partials 163 162 -1
Continue to review full report at Codecov.
|
dlorenc
reviewed
May 19, 2017
| @@ -28,4 +28,4 @@ var SupportedVMDrivers = [...]string{ | |||
| } | |||
|
|
|||
| var DefaultMountDir = homedir.HomeDir() | |||
| var DefaultMountEndpoint = "/hosthome" | |||
| var DefaultMountEndpoint = "/mount-9p" | |||
There was a problem hiding this comment.
Since these are the same across all drivers now (which makes sense), could you move it out of the constants_$OS file into the main one?
Also WDYT of making this "/minikube-host" or something.
…ies than the current mounts until they are turned off.
dlorenc
approved these changes
May 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ies than the current mounts until they are turned off.