Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if addon has no associated Github username #15081

Merged
merged 4 commits into from
Oct 10, 2022

Conversation

klaases
Copy link
Contributor

@klaases klaases commented Oct 6, 2022

Fixes: #15063

Add an additional check to warn whether a 3rd party addon lacks a verified maintainer / associated Github username. We want to warn the user about addons without a maintainer as they may become deprecated over time.

Before:

Without verified maintainer (without extra warning):

$ ./out/minikube addons enable registry-aliases
❗  registry-aliases is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.
    ▪ Using image quay.io/rhdevelopers/core-dns-patcher
    ▪ Using image docker.io/alpine:3.11
    ▪ Using image gcr.io/google_containers/pause:3.1
🌟  The 'registry-aliases' addon is enabled

After:

Without verified maintainer (with extra warning):

$ ./out/minikube addons enable registry-aliases
❗  registry-aliases is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.
❗  registry-aliases does not currently have an associated maintainer.
    ▪ Using image quay.io/rhdevelopers/core-dns-patcher
    ▪ Using image docker.io/alpine:3.11
    ▪ Using image gcr.io/google_containers/pause:3.1
🌟  The 'registry-aliases' addon is enabled

Same before and after:

With verified maintainer:

$ ./out/minikube addons enable storage-provisioner
💡  storage-provisioner is an addon maintained by Google. For any concerns contact minikube on GitHub.
You can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  The 'storage-provisioner' addon is enabled
16:10:53 jklaas/minikube
warn1 •2 ✭2

Reference:

Addons List

./out/minikube addons list

|-----------------------------|----------|--------------|--------------------------------|
|         ADDON NAME          | PROFILE  |    STATUS    |           MAINTAINER           |
|-----------------------------|----------|--------------|--------------------------------|
| ambassador                  | minikube | disabled     | 3rd party (Ambassador)         |
| auto-pause                  | minikube | disabled     | Google                         |
| csi-hostpath-driver         | minikube | disabled     | Kubernetes                     |
| dashboard                   | minikube | disabled     | Kubernetes                     |
| default-storageclass        | minikube | enabled ✅   | Kubernetes                     |
| efk                         | minikube | disabled     | 3rd party (Elastic)            |
| freshpod                    | minikube | disabled     | Google                         |
| gcp-auth                    | minikube | disabled     | Google                         |
| gvisor                      | minikube | disabled     | Google                         |
| headlamp                    | minikube | disabled     | 3rd party (kinvolk.io)         |
| helm-tiller                 | minikube | disabled     | 3rd party (Helm)               |
| inaccel                     | minikube | disabled     | 3rd party (InAccel             |
|                             |          |              | [info@inaccel.com])            |
| ingress                     | minikube | disabled     | Kubernetes                     |
| ingress-dns                 | minikube | disabled     | Google                         |
| istio                       | minikube | disabled     | 3rd party (Istio)              |
| istio-provisioner           | minikube | disabled     | 3rd party (Istio)              |
| kong                        | minikube | disabled     | 3rd party (Kong HQ)            |
| kubevirt                    | minikube | disabled     | 3rd party (KubeVirt)           |
| logviewer                   | minikube | disabled     | 3rd party (unknown)            |
| metallb                     | minikube | disabled     | 3rd party (MetalLB)            |
| metrics-server              | minikube | disabled     | Kubernetes                     |
| nvidia-driver-installer     | minikube | disabled     | Google                         |
| nvidia-gpu-device-plugin    | minikube | disabled     | 3rd party (Nvidia)             |
| olm                         | minikube | enabled ✅   | 3rd party (Operator Framework) |
| pod-security-policy         | minikube | disabled     | 3rd party (unknown)            |
| portainer                   | minikube | disabled     | 3rd party (Portainer.io)       |
| registry                    | minikube | disabled     | Google                         |
| registry-aliases            | minikube | enabled ✅   | 3rd party (unknown)            |
| registry-creds              | minikube | disabled     | 3rd party (UPMC Enterprises)   |
| storage-provisioner         | minikube | enabled ✅   | Google                         |
| storage-provisioner-gluster | minikube | disabled     | 3rd party (Gluster)            |
| volumesnapshots             | minikube | disabled     | Kubernetes                     |
|-----------------------------|----------|--------------|--------------------------------|

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 6, 2022
@klaases klaases self-assigned this Oct 6, 2022
@spowelljr
Copy link
Member

Can you run make generate-docs to update the translations

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2022
@klaases
Copy link
Contributor Author

klaases commented Oct 7, 2022

Can you run make generate-docs to update the translations

Yes, updated translation, thanks.

translations/fr.json Outdated Show resolved Hide resolved
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
@spowelljr spowelljr merged commit f981dd1 into kubernetes:master Oct 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn user if an addon does NOT have a github username attached to
3 participants