Use SSH tunnel if user specifies bindAddress

[spowelljr]

Fixes #14712

Currently, if the user is on Linux and using the Docker driver, specifying the bindAddress doesn't take effect as driver.NeedsPortForward returns false and the SSH tunnel is not used.

Updated the logic gating so if the user is on Linux and using the Docker driver and they specify the bindAddress it will use the SSH tunnel.

[klaases]

Summary: if it is not KIC, false, else use SSH tunnel if needs port forward or has a bind address.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[spowelljr]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14951) |
+----------------+----------+---------------------+
| minikube start | 55.6s    | 55.0s               |
| enable ingress | 28.4s    | 27.8s               |
+----------------+----------+---------------------+

Times for minikube start: 53.9s 55.3s 56.2s 55.2s 57.5s
Times for minikube (PR 14951) start: 55.4s 54.1s 55.3s 55.3s 55.1s

Times for minikube ingress: 28.1s 28.7s 28.6s 28.2s 28.7s
Times for minikube (PR 14951) ingress: 28.1s 29.1s 26.6s 27.2s 28.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14951) |
+----------------+----------+---------------------+
| minikube start | 27.4s    | 28.1s               |
| enable ingress | 22.9s    | 23.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.9s 23.5s 22.5s 22.5s 23.0s
Times for minikube (PR 14951) ingress: 24.0s 24.0s 24.5s 23.0s 22.0s

Times for minikube start: 28.0s 28.7s 26.7s 26.5s 27.1s
Times for minikube (PR 14951) start: 29.9s 27.0s 28.0s 27.7s 27.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14951) |
+----------------+----------+---------------------+
| minikube start | 22.7s    | 23.0s               |
| enable ingress | 27.3s    | 27.4s               |
+----------------+----------+---------------------+

Times for minikube start: 21.9s 23.0s 22.8s 22.9s 22.8s
Times for minikube (PR 14951) start: 23.1s 23.0s 23.3s 22.5s 22.8s

Times for minikube ingress: 27.0s 27.0s 27.5s 27.5s 27.5s
Times for minikube (PR 14951) ingress: 27.5s 27.5s 27.0s 27.5s 27.5s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestDownloadOnly/v1.25.2/preload-exists (gopogh)	n/a
Docker_macOS	TestAddons/Setup (gopogh)	0.00 (chart)
Docker_macOS	TestBinaryMirror (gopogh)	0.00 (chart)
Docker_macOS	TestDownloadOnlyKic (gopogh)	0.00 (chart)
Docker_macOS	TestErrorSpam/setup (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/MountCmd/any-port (gopogh)	0.00 (chart)
Hyperkit_macOS	TestJSONOutput/pause/Command (gopogh)	3.65 (chart)
Hyperkit_macOS	TestJSONOutput/start/Command (gopogh)	3.65 (chart)
Hyperkit_macOS	TestJSONOutput/unpause/Command (gopogh)	3.65 (chart)
Docker_Linux	TestMultiNode/serial/StartAfterStop (gopogh)	8.55 (chart)
none_Linux	TestAddons/parallel/MetricsServer (gopogh)	12.50 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	20.59 (chart)
Docker_Linux_containerd	TestOffline (gopogh)	26.11 (chart)
Docker_Linux_containerd	TestAddons/Setup (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestFunctional/parallel/DashboardCmd (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MountCmd/any-port (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MySQL (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmd (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmdConnect (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestFunctional/serial/ExtraConfig (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestFunctional/serial/SoftStart (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestFunctional/serial/StartWithProxy (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Command (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestMultiNode/serial/AddNode (gopogh)	28.03 (chart)
Docker_Linux_containerd	TestMultiNode/serial/DeployApp2Nodes (gopogh)	28.03 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.