Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kicbase base image #14904

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Update kicbase base image #14904

merged 2 commits into from
Sep 6, 2022

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Sep 2, 2022 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 2, 2022
@spowelljr
Copy link
Member Author

ok-to-build-image

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2022
@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 2, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14904) |
+----------------+----------+---------------------+
| minikube start | 57.1s    | 55.8s               |
| enable ingress | 27.5s    | 26.9s               |
+----------------+----------+---------------------+

Times for minikube start: 57.2s 58.1s 56.9s 57.9s 55.6s
Times for minikube (PR 14904) start: 55.5s 55.8s 56.5s 55.6s 55.7s

Times for minikube ingress: 26.6s 30.1s 25.6s 29.1s 26.1s
Times for minikube (PR 14904) ingress: 28.6s 29.1s 25.6s 25.6s 25.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14904) |
+----------------+----------+---------------------+
| minikube start | 28.0s    | 28.3s               |
| enable ingress | 23.2s    | 23.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 24.0s 22.0s 23.0s 23.0s 24.0s
Times for minikube (PR 14904) ingress: 22.0s 22.5s 24.5s 24.0s 23.5s

Times for minikube start: 28.0s 28.5s 27.8s 27.9s 28.0s
Times for minikube (PR 14904) start: 29.7s 28.4s 27.6s 27.5s 28.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14904) |
+----------------+----------+---------------------+
| minikube start | 24.1s    | 26.8s               |
| enable ingress | 27.1s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.4s 27.0s 27.0s 27.0s 26.9s
Times for minikube (PR 14904) ingress: 27.0s 27.0s 27.0s 27.0s 27.0s

Times for minikube start: 23.4s 25.0s 23.5s 24.7s 23.9s
Times for minikube (PR 14904) start: 24.9s 24.9s 24.2s 35.7s 24.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestNetworkPlugins/group/auto/DNS (gopogh) 0.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 9.45 (chart)
Docker_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 11.88 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 14.65 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 27.70 (chart)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 30.36 (chart)
KVM_Linux TestMultiNode/serial/RestartMultiNode (gopogh) 46.43 (chart)
Docker_Windows TestAddons/Setup (gopogh) 52.26 (chart)
Docker_Windows TestCertOptions (gopogh) 52.26 (chart)
Docker_Windows TestDockerFlags (gopogh) 52.26 (chart)
Docker_Windows TestErrorSpam/setup (gopogh) 52.26 (chart)
Docker_Windows TestForceSystemdEnv (gopogh) 52.26 (chart)
Docker_Windows TestForceSystemdFlag (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/CertSync (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/CpCmd (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/DockerEnv/powershell (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/FileSync (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/Setup (gopogh) 52.26 (chart)
Docker_Windows TestFunctional/parallel/MySQL (gopogh) 52.26 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 8d0cd99 into kubernetes:master Sep 6, 2022
@spowelljr spowelljr deleted the updateBaseImage branch September 6, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spowelljr @minikube-bot @minikube-pr-bot @k8s-ci-robot @medyagh