Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Update Docker from 20.10.16 to 20.10.17 #14534

Merged
merged 3 commits into from
Jul 11, 2022
Merged

ISO: Update Docker from 20.10.16 to 20.10.17 #14534

merged 3 commits into from
Jul 11, 2022

Conversation

spowelljr
Copy link
Member

https://docs.docker.com/engine/release-notes/#201017

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2022
@spowelljr
Copy link
Member Author

ok-to-build-iso

@kubernetes kubernetes deleted a comment from minikube-bot Jul 8, 2022
@minikube-bot
Copy link
Collaborator

Hi @spowelljr, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/14534/d3f6550/iso_build.txt

@spowelljr
Copy link
Member Author 

ERROR: a916309fff0f838eb94e928713dbc3c0d0ac7aa4.tar.gz has wrong sha256 hash:
ERROR: expected: 0ccce82b1d9c058d8fd7443d261c96fd7a803f2775bcb1fec2bdb725bc7640f6
ERROR: got     : 9bb3be747237647cd232a47796d855e44fe295493f9661a4013835393ea65d46
ERROR: Incomplete download, or man-in-the-middle (MITM) attack

Looks like I might have grabbed the wrong SHA

@spowelljr
Copy link
Member Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 9, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14534) |
+----------------+----------+---------------------+
| minikube start | 57.5s    | 56.5s               |
| enable ingress | 39.6s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube start: 57.0s 58.0s 58.3s 57.7s 56.7s
Times for minikube (PR 14534) start: 56.7s 56.1s 55.0s 57.0s 57.7s

Times for minikube ingress: 25.6s 29.1s 28.7s 85.6s 29.1s
Times for minikube (PR 14534) ingress: 25.1s 28.6s 30.1s 29.1s 29.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14534) |
+----------------+----------+---------------------+
| minikube start | 28.5s    | 28.4s               |
| enable ingress | 22.5s    | 22.6s               |
+----------------+----------+---------------------+

Times for minikube start: 27.7s 29.1s 29.1s 28.2s 28.2s
Times for minikube (PR 14534) start: 27.0s 28.5s 29.6s 28.6s 28.3s

Times for minikube ingress: 22.9s 22.9s 21.9s 23.0s 21.9s
Times for minikube (PR 14534) ingress: 22.0s 21.9s 25.0s 22.5s 21.4s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14534) |
+-------------------+----------+---------------------+
| minikube start    | 26.5s    | 28.7s               |
| ⚠️  enable ingress | 27.3s    | 33.2s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 24.7s 24.9s 34.5s 24.1s 24.4s
Times for minikube (PR 14534) start: 36.1s 24.0s 24.0s 24.3s 34.9s

Times for minikube ingress: 27.4s 27.4s 27.5s 27.0s 27.0s
Times for minikube (PR 14534) ingress: 26.9s 26.9s 57.4s 27.0s 27.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 4.20 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 4.73 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 4.73 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 4.73 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 4.73 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 4.73 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 4.73 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 5.11 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 5.11 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 5.11 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 5.11 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 5.11 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 5.11 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 5.11 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/Stop (gopogh) 5.11 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr
Copy link
Member Author

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14534) |
+----------------+----------+---------------------+
| minikube start | 56.2s    | 56.2s               |
| enable ingress | 28.0s    | 28.8s               |
+----------------+----------+---------------------+

Times for minikube start: 55.7s 55.7s 56.1s 56.1s 57.1s
Times for minikube (PR 14534) start: 55.4s 57.5s 56.8s 55.8s 55.5s

Times for minikube (PR 14534) ingress: 26.1s 29.1s 30.6s 29.5s 28.6s
Times for minikube ingress: 26.1s 30.6s 28.5s 29.0s 25.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14534) |
+----------------+----------+---------------------+
| minikube start | 28.1s    | 28.8s               |
| enable ingress | 33.9s    | 22.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 14534) start: 28.0s 28.5s 31.9s 27.6s 27.8s
Times for minikube start: 29.0s 28.0s 27.4s 29.1s 27.0s

Times for minikube (PR 14534) ingress: 23.0s 23.9s 22.4s 22.9s 22.4s
Times for minikube ingress: 83.4s 22.9s 20.9s 20.9s 21.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14534) |
+----------------+----------+---------------------+
| minikube start | 23.9s    | 28.3s               |
| enable ingress | 26.9s    | 26.8s               |
+----------------+----------+---------------------+

Times for minikube start: 23.9s 24.6s 23.5s 23.9s 23.7s
Times for minikube (PR 14534) start: 24.5s 23.8s 24.1s 34.8s 34.2s

Times for minikube ingress: 27.4s 26.4s 27.0s 27.0s 26.4s
Times for minikube (PR 14534) ingress: 26.4s 27.4s 26.4s 26.9s 26.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/DeployApp (gopogh) 17.07 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/FirstStart (gopogh) 17.07 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/SecondStart (gopogh) 17.07 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 17.07 (chart)
Hyperkit_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 20.41 (chart)
Docker_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 21.05 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 30.89 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 30.89 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 31.45 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 31.45 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 43.09 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 43.09 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 43.55 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 44.00 (chart)
KVM_Linux TestMultiNode/serial/RestartMultiNode (gopogh) 51.28 (chart)
Docker_Windows TestStartStop/group/no-preload/serial/Pause (gopogh) 54.48 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 54.67 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 68.28 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 70.37 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 70.67 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 71.77 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 73.85 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 81.10 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 81.71 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 81.71 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 82.93 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 84.15 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 95.21 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 95.71 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr changed the title Update Docker from 20.10.16 to 20.10.17 ISO: Update Docker from 20.10.16 to 20.10.17 Jul 11, 2022
klaases
klaases approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@klaases klaases left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 5b91e27 into kubernetes:master Jul 11, 2022
@spowelljr spowelljr deleted the updateContainerd branch July 11, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaases klaases klaases approved these changes

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spowelljr @minikube-bot @minikube-pr-bot @k8s-ci-robot @medyagh @klaases