-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the container runtime when running without kubernetes #13432 #14200
Conversation
Create a showNotK8sVersionInfo func to output the runtime and runtime version
When minikube is started without kubernetes, check runtime is compatible and if so call func to output runtime and runtime version
"Starting minikube without Kubernetes {Machine Name} in cluster {cluster}" doesn't make sense so removing the Machine name var from output.
Welcome @Gimb0! |
Hi @Gimb0. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
@afbjorklund - Can you please review this PR and give me any feedback you may have? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output (and code) looks good to me, thanks for fixing!
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 53.0s 51.3s 51.7s 52.0s 51.1s Times for minikube ingress: 29.6s 29.1s 29.6s 29.6s 29.2s docker driver with docker runtime
Times for minikube start: 29.2s 25.1s 26.0s 24.5s 25.2s Times for minikube ingress: 22.4s 21.9s 22.9s 22.9s 21.9s docker driver with containerd runtime
Times for minikube ingress: 18.9s 21.9s 22.4s 32.4s 22.4s Times for minikube start: 35.3s 29.2s 28.8s 28.3s 28.7s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
There's also a lint issue: pkg/minikube/node/start.go:105: File is not |
Correct lint with gofmt -s pkg/minikube/node/start.go
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
kvm2 driver with docker runtime
Times for minikube start: 54.3s 50.0s 50.6s 52.0s 51.3s Times for minikube (PR 14200) ingress: 25.0s 26.0s 27.5s 29.0s 26.0s docker driver with docker runtime
Times for minikube start: 29.0s 24.0s 23.0s 23.4s 23.8s Times for minikube ingress: 22.4s 22.9s 23.4s 26.4s 22.9s docker driver with containerd runtime
Times for minikube ingress: 22.4s 22.4s 22.4s 32.4s 18.9s Times for minikube (PR 14200) start: 32.2s 29.7s 28.9s 32.5s 28.5s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
kvm2 driver with docker runtime
Times for minikube ingress: 29.6s 25.1s 28.1s 34.6s 29.1s Times for minikube start: 49.5s 50.7s 52.2s 51.1s 49.0s docker driver with docker runtime
Times for minikube start: 23.8s 24.0s 23.9s 25.1s 24.9s Times for minikube ingress: 23.9s 23.9s 22.9s 22.4s 23.9s docker driver with containerd runtime
Times for minikube start: 40.3s 43.8s 43.8s 32.2s 33.1s Times for minikube ingress: 22.4s 17.9s 28.4s 18.9s 28.4s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, Gimb0, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #13432
In summary it is to show the runtime used when --no-kubernetes option is used to start minikube.
Also improves the readability of the sentence "Starting minikube without Kubernetes {machine name} in cluster {cluster}" by removing the machine name.
Changes to UI
Before:
After: