-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nginx image #14028
Update nginx image #14028
Conversation
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 52.0s 51.8s 50.8s 50.9s 49.7s Times for minikube ingress: 30.0s 28.6s 24.6s 29.0s 25.5s docker driver with docker runtime
Times for minikube start: 24.6s 24.7s 24.8s 24.6s 24.4s Times for minikube ingress: 22.9s 22.4s 23.4s 22.9s 22.4s docker driver with containerd runtime
Times for minikube start: 29.5s 38.8s 43.3s 38.4s 39.7s Times for minikube ingress: 22.4s 22.4s 27.9s 22.4s 22.4s |
Remove the swp file before merging. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3c06383
to
1bcdaea
Compare
Removed, thanks for catching that |
References kubernetes/kubernetes#126812 kubernetes/kubernetes#126813