Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker requirement for none driver #13885

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Remove docker requirement for none driver #13885

merged 1 commit into from
Apr 5, 2022

Conversation

staticdev
Copy link
Contributor

@staticdev staticdev commented Mar 30, 2022

  • Removed docker validation on none driver. This validation does not make sense since it run for all other container-runtimes, even when not using docker. It is also redundant with the same validation on docker runtime side.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @staticdev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 30, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@afbjorklund
Copy link
Collaborator

This check should be removed, but the underlying issue still needs to be fixed. It will still fail, just somewhat later.

So while I support removing it, it will not fix the issue where running the "none" driver requires a fake docker binary

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2022
@staticdev
Copy link
Contributor Author

You are right @afbjorklund. I removed the fixed #10908 from this PR. Maybe I follow up with another PR as the discussion in the issue evolves.

@staticdev
Copy link
Contributor Author

@prasadkatti
@sharifelgamal
LGTM?

@sharifelgamal
Copy link
Collaborator

/ok-to-test

makes sense to me, let's make sure the tests don't complain, not that they should.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13885) |
+----------------+----------+---------------------+
| minikube start | 63.7s    | 63.0s               |
| enable ingress | 28.1s    | 29.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 13885) start: 63.4s 63.1s 62.9s 62.2s 63.6s
Times for minikube start: 64.8s 64.1s 63.4s 62.6s 63.8s

Times for minikube ingress: 25.6s 28.5s 28.1s 29.1s 29.1s
Times for minikube (PR 13885) ingress: 28.6s 30.6s 29.5s 30.1s 29.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13885) |
+----------------+----------+---------------------+
| minikube start | 36.2s    | 36.2s               |
| enable ingress | 23.1s    | 23.4s               |
+----------------+----------+---------------------+

Times for minikube start: 37.4s 35.9s 35.6s 35.8s 36.3s
Times for minikube (PR 13885) start: 36.2s 35.8s 36.8s 36.2s 36.1s

Times for minikube ingress: 21.9s 23.0s 23.9s 22.9s 24.0s
Times for minikube (PR 13885) ingress: 22.9s 23.9s 22.4s 22.9s 24.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13885) |
+----------------+----------+---------------------+
| minikube start | 60.0s    | 61.2s               |
| enable ingress | 26.0s    | 23.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 30.4s 21.9s 26.5s 28.9s 22.4s
Times for minikube (PR 13885) ingress: 31.5s 21.9s 21.4s 21.4s 23.4s

Times for minikube start: 51.1s 61.6s 63.2s 62.6s 61.3s
Times for minikube (PR 13885) start: 61.4s 61.3s 61.0s 59.2s 62.9s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, sharifelgamal, staticdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sharifelgamal sharifelgamal merged commit 3531e25 into kubernetes:master Apr 5, 2022
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestSkaffold (gopogh) 2.04 (chart)
Docker_Linux TestNoKubernetes/serial/Start (gopogh) 4.76 (chart)
Docker_Linux TestStartStop/group/no-preload/serial/Pause (gopogh) 4.76 (chart)
KVM_Linux_containerd TestErrorSpam/setup (gopogh) 7.88 (chart)
KVM_Linux TestErrorSpam/setup (gopogh) 7.88 (chart)
Hyperkit_macOS TestErrorSpam/setup (gopogh) 9.68 (chart)
Docker_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 9.77 (chart)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 10.53 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh) 16.11 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/EnableAddonAfterStop (gopogh) 16.67 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/Stop (gopogh) 16.67 (chart)
Docker_Linux TestPause/serial/Pause (gopogh) 17.12 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/UserAppExistsAfterStop (gopogh) 17.22 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/SecondStart (gopogh) 17.76 (chart)
Docker_Windows TestPause/serial/Pause (gopogh) 26.27 (chart)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 40.14 (chart)
Docker_macOS TestNetworkPlugins/group/custom-weave/Start (gopogh) 47.69 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/DNS (gopogh) 55.56 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 61.04 (chart)
Docker_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 63.27 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 74.83 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 75.51 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 76.87 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 77.44 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 78.91 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Docker_Windows TestSkaffold (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@staticdev staticdev deleted the patch-staticdev-1 branch April 6, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants