Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Podman: fix minikube delete for Podman v4 #13881

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Podman: fix minikube delete for Podman v4 #13881

merged 1 commit into from
Mar 31, 2022

Conversation

AkihiroSuda
Copy link
Member

The "minikube" network was not deleted due to the breaking change of podman network inspect in Podman v4.

Fixes #13861

@AkihiroSuda
Podman: fix minikube delete for Podman v4
28fdc99 
The "minikube" network was not deleted due to the breaking change of
`podman network inspect` in Podman v4.

Fix issue 13861

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2022
@AkihiroSuda AkihiroSuda mentioned this pull request Mar 30, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 30, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 30, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13881) |
+----------------+----------+---------------------+
| minikube start | 52.1s    | 52.6s               |
| enable ingress | 28.9s    | 28.2s               |
+----------------+----------+---------------------+

Times for minikube start: 51.6s 51.9s 51.4s 53.0s 52.6s
Times for minikube (PR 13881) start: 52.5s 51.7s 53.1s 52.4s 53.3s

Times for minikube ingress: 29.1s 30.1s 29.1s 29.5s 26.6s
Times for minikube (PR 13881) ingress: 30.0s 26.6s 26.0s 29.0s 29.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13881) |
+----------------+----------+---------------------+
| minikube start | 26.5s    | 26.3s               |
| enable ingress | 22.7s    | 22.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 13881) start: 25.1s 26.9s 26.2s 27.0s 26.2s
Times for minikube start: 28.0s 25.5s 26.3s 26.4s 26.0s

Times for minikube ingress: 22.4s 21.9s 23.4s 22.9s 23.0s
Times for minikube (PR 13881) ingress: 21.9s 21.9s 24.0s 22.9s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13881) |
+----------------+----------+---------------------+
| minikube start | 41.7s    | 41.9s               |
| enable ingress | 20.0s    | 21.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 21.9s 18.4s 18.9s 18.9s 21.9s
Times for minikube (PR 13881) ingress: 22.4s 21.9s 22.4s 19.4s 22.4s

Times for minikube start: 31.4s 46.0s 44.9s 44.6s 41.6s
Times for minikube (PR 13881) start: 41.1s 41.2s 41.9s 45.1s 40.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnly/v1.23.6-rc.0/preload-exists (gopogh) 0.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/NetCatPod (gopogh) 2.17 (chart)
Docker_Linux TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 3.09 (chart)
Hyper-V_Windows TestPause/serial/PauseAgain (gopogh) 3.55 (chart)
Docker_Linux_containerd TestPause/serial/Pause (gopogh) 4.51 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 4.55 (chart)
Docker_macOS TestDownloadOnly/v1.23.5/preload-exists (gopogh) 5.00 (chart)
Docker_Linux TestNetworkPlugins/group/calico/NetCatPod (gopogh) 18.75 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 40.97 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 42.47 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/Start (gopogh) 43.21 (chart)
Hyper-V_Windows TestSkaffold (gopogh) 52.08 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/DNS (gopogh) 55.38 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 57.75 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 59.22 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 59.72 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 61.27 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 63.16 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 71.60 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 73.46 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 74.07 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 76.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 80.33 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 81.06 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr
Copy link
Member

spowelljr commented Mar 30, 2022 •
edited
Loading

Thanks for the PR @AkihiroSuda, I'm going to manually downloading the two Podman versions and test this manually tomorrow and as long as all is good I'll merge it

@spowelljr spowelljr merged commit ad4d80e into kubernetes:master Mar 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Podman v4] minikube delete does not remove Podman's minikube network
5 participants
@AkihiroSuda @minikube-bot @spowelljr @minikube-pr-bot @k8s-ci-robot