-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KIC: Update kicbase base image #13815
Conversation
ok-to-build-image |
Hi @afbjorklund, building a new kicbase image failed. |
Looks like auto-pause is broken: #69 93.03 /go/pkg/mod/sigs.k8s.io/json@v0.0.0-20211020170558-c049b76a60c6/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported) It needs go1.17 (and a git repo...) |
ok-to-build-image |
Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further. |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 54.1s 51.8s 52.0s 52.2s 51.8s Times for minikube ingress: 25.0s 29.0s 25.5s 25.0s 28.5s docker driver with docker runtime
Times for minikube start: 29.7s 25.6s 25.2s 25.0s 26.0s Times for minikube ingress: 23.4s 22.4s 22.9s 21.9s 21.9s docker driver with containerd runtime
Times for minikube start: 31.9s 42.5s 45.4s 41.2s 41.2s Times for minikube ingress: 32.9s 23.4s 18.9s 32.9s 54.4s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
BEFORE
34 packages can be upgraded.
AFTER
All packages are up to date.