New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update auto-generated docs and translations #13785

Closed

minikube-bot wants to merge 1 commit into kubernetes:master from minikube-bot:gendocs

Collaborator

minikube-bot commented Mar 15, 2022

Committing changes resulting from make generate-docs.
This PR is auto-generated by the gendocs CI workflow.

 M translations/de.json
 M translations/es.json
 M translations/fr.json
 M translations/ja.json
 M translations/ko.json
 M translations/pl.json
 M translations/ru.json
 M translations/strings.txt
 M translations/zh-CN.json

k8s-ci-robot added cncf-cla: yes needs-ok-to-test labels

Contributor

k8s-ci-robot commented Mar 15, 2022

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the size/S label

Contributor

k8s-ci-robot commented Mar 15, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minikube-bot
To complete the pull request process, please assign sharifelgamal after the PR has been reviewed.
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from klaases and prezha

March 15, 2022 01:22

Collaborator Author

minikube-bot commented Mar 15, 2022

Can one of the admins verify this patch?

minikube-bot force-pushed the gendocs branch 3 times, most recently from b15751c to 139a50e Compare

March 16, 2022 18:16

klaases reviewed

View reviewed changes

translations/de.json

@@ @@ -1000,7 +1000,9 @@ @@
               	"{{.name}} was successfully configured": "{{.name}} wurde erfolgreich konfiguriert",
               	"{{.name}}\" profile does not exist": "Profil \"{{.name}}\" existiert nicht",
               	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity)": "{{.n}} hat fast keinen Plattenplatz mehr. Dies kann dazu führen, dass Deployments fehlschlagen! ({{.p}}% der Kapazität)",

Contributor

klaases Mar 16, 2022

Should this line be removed, since it has been updated below?

klaases reviewed

View reviewed changes

translations/de.json

@@ @@ -1000,7 +1000,9 @@ @@
               	"{{.name}} was successfully configured": "{{.name}} wurde erfolgreich konfiguriert",
               	"{{.name}}\" profile does not exist": "Profil \"{{.name}}\" existiert nicht",
               	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity)": "{{.n}} hat fast keinen Plattenplatz mehr. Dies kann dazu führen, dass Deployments fehlschlagen! ({{.p}}% der Kapazität)",
+              	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity). You can pass '--force' to skip this check.": "",
               	"{{.n}} is out of disk space! (/var is at {{.p}}% of capacity)": "{{.n}} hat keinen Plattenplatz mehr! (/var ist bei {{.p}}% seiner Kapazität)",

Contributor

klaases Mar 16, 2022

Should this line be removed, since it has been updated below?

klaases reviewed

View reviewed changes

translations/fr.json

@@ @@ -966,7 +966,9 @@ @@
               	"{{.name}} is already running": "{{.name}} est déjà en cours d'exécution",
               	"{{.name}} was successfully configured": "{{.name}} a été configuré avec succès",
               	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity)": "{{.n}} manque presque d'espace disque, ce qui peut entraîner l'échec des déploiements ! ({{.p}} % de la capacité)",

Contributor

klaases Mar 16, 2022

Should this line be removed, since it has been updated below?

klaases reviewed

View reviewed changes

translations/fr.json

@@ @@ -966,7 +966,9 @@ @@
               	"{{.name}} is already running": "{{.name}} est déjà en cours d'exécution",
               	"{{.name}} was successfully configured": "{{.name}} a été configuré avec succès",
               	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity)": "{{.n}} manque presque d'espace disque, ce qui peut entraîner l'échec des déploiements ! ({{.p}} % de la capacité)",
+              	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity). You can pass '--force' to skip this check.": "",
               	"{{.n}} is out of disk space! (/var is at {{.p}}% of capacity)": "{{.n}} n'a plus d'espace disque ! (/var est à {{.p}} % de capacité)",

Contributor

klaases Mar 16, 2022

Should this line be removed, since it has been updated below?

klaases reviewed

View reviewed changes

translations/ru.json

@@ @@ -935,7 +935,9 @@ @@
               	"{{.name}} is already running": "",
               	"{{.name}} was successfully configured": "",
               	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity)": "В {{.n}} заканчивается место на диске, что может привести к проблемам в работе! ({{.p}}% занято)",

Contributor

klaases Mar 16, 2022

Should this line be removed, since it has been updated below?

klaases reviewed

View reviewed changes

translations/ru.json

@@ @@ -935,7 +935,9 @@ @@
               	"{{.name}} is already running": "",
               	"{{.name}} was successfully configured": "",
               	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity)": "В {{.n}} заканчивается место на диске, что может привести к проблемам в работе! ({{.p}}% занято)",
+              	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity). You can pass '--force' to skip this check.": "",
               	"{{.n}} is out of disk space! (/var is at {{.p}}% of capacity)": "В {{.n}} закончилось место! (в /var занято {{.p}}%)",

Contributor

klaases Mar 16, 2022

Should this line be removed, since it has been updated below?

klaases reviewed

View reviewed changes

translations/pl.json

@@ @@ -1015,7 +1015,9 @@ @@
               	"{{.name}} is already running": "{{.name}} został już wcześniej uruchomiony",
               	"{{.name}} was successfully configured": "{{.name}} skonfigurowano pomyślnie",
               	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity)": "{{.n}} prawie nie ma wolnej przestrzeni dyskowej, co może powodować, że wdrożenia nie powiodą się ({{.p}}% zużycia przestrzeni dyskowej)",
+              	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity). You can pass '--force' to skip this check.": "",
               	"{{.n}} is out of disk space! (/var is at {{.p}}% of capacity)": "{{.n}} nie ma wolnej przestrzeni dyskowej! (/var jest w {{.p}}% pełny)",

Contributor

klaases Mar 16, 2022

Should this line be removed, since it has been updated below?

klaases reviewed

View reviewed changes

translations/pl.json

@@ @@ -1015,7 +1015,9 @@ @@
               	"{{.name}} is already running": "{{.name}} został już wcześniej uruchomiony",
               	"{{.name}} was successfully configured": "{{.name}} skonfigurowano pomyślnie",
               	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity)": "{{.n}} prawie nie ma wolnej przestrzeni dyskowej, co może powodować, że wdrożenia nie powiodą się ({{.p}}% zużycia przestrzeni dyskowej)",

Contributor

klaases Mar 16, 2022

Should this line be removed, since it has been updated below?

klaases reviewed

View reviewed changes

translations/ja.json

@@ @@ -1024,7 +1024,9 @@ @@
               	"{{.name}} is already running": "{{.name}} はすでに実行中です",
               	"{{.name}} was successfully configured": "{{.name}} は正常に設定されました",
               	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity)": "{{.n}} はほとんどディスクがいっぱいで、デプロイが失敗する原因になりかねません！(容量の {{.p}}%)",
+              	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity). You can pass '--force' to skip this check.": "",
               	"{{.n}} is out of disk space! (/var is at {{.p}}% of capacity)": "{{.n}} はディスクがいっぱいです！(/var は容量の {{.p}}% です)",

Contributor

klaases Mar 16, 2022

Should this line be removed, since it has been updated below?

klaases reviewed

View reviewed changes

translations/ja.json

@@ @@ -1024,7 +1024,9 @@ @@
               	"{{.name}} is already running": "{{.name}} はすでに実行中です",
               	"{{.name}} was successfully configured": "{{.name}} は正常に設定されました",
               	"{{.n}} is nearly out of disk space, which may cause deployments to fail! ({{.p}}% of capacity)": "{{.n}} はほとんどディスクがいっぱいで、デプロイが失敗する原因になりかねません！(容量の {{.p}}%)",

Contributor

klaases Mar 16, 2022

Should this line be removed, since it has been updated below?

klaases reviewed

View reviewed changes

Contributor

klaases left a comment

Some of the files remove the reference to {{.n}}, while others do not.

Should the previous {{.n}} lines be removed, since they have been updated below?

Contributor

klaases commented Mar 16, 2022

Ok, I realize my comments were going to the bot. Perhaps we can manually edit these translation files.

minikube-bot force-pushed the gendocs branch from 139a50e to e1dc5e5 Compare

March 16, 2022 22:39


          Update auto-generated docs and translations

a423dc0

minikube-bot force-pushed the gendocs branch from e1dc5e5 to a423dc0 Compare

March 16, 2022 22:51

Member

spowelljr commented Mar 16, 2022

@klaases Generally it's best to leave the outdated comments as then when someone comes in to translate the new version they can reference the existing line and only have the add the small amount that has changed. If there has been no translation provided yet then it will delete the existing one if it is longer being used anywhere else.

Contributor

klaases commented Mar 22, 2022

Sounds good, thanks @spowelljr, will leave as-is for now.

Member

spowelljr commented Mar 22, 2022

These got merged with #13802

spowelljr closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes needs-ok-to-test size/S