-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update minikube drivers to call out apple silicon support #13574
docs: update minikube drivers to call out apple silicon support #13574
Conversation
Hi @danielhelfand. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danielhelfand The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
53fe91f
to
f54c164
Compare
f54c164
to
1dc0824
Compare
@@ -31,6 +31,14 @@ To do so, we use the [Docker Machine](https://github.com/docker/machine) library | |||
* [VMware Fusion]({{<ref "vmware.md">}}) - VM | |||
* [SSH]({{<ref "ssh.md">}}) - remote ssh | |||
|
|||
### macOS M1 (Silicon) | |||
|
|||
The following drivers support macOS M1 users: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it would be better if this talked about CPU architectures (arm64) rather than CPU models.
There is nothing magic about Apple M1 (that wouldn't apply to M2), and the issue is the same on Linux.
I'm not sure if podman on mac works at all for minikube, but I guess it is "experimental" after all.
The CoreOS VM image is available as aarch64 (and x86_64), so it should be possible to test it at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it would be better if this talked about CPU architectures (arm64) rather than CPU models.
There is nothing magic about Apple M1 (that wouldn't apply to M2), and the issue is the same on Linux.
In your mind, would it be better to have an arm64
for each os?
I'm not sure if podman on mac works at all for minikube, but I guess it is "experimental" after all.
I think it's fair to remove this. I could at least not personally get it working.
After we forked the docker-machine drivers, it is hard to test them with any other ISO image (than minikube) |
Hi @afbjorklund, based on @danielhelfand's comment, do you think it is better to break out an arm64 section for each OS? As an aside, we might end up with a kind of table or grid to handle multiple combinations. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closes #13572
This pull request adds details on Apple Silicon support for minikube driver options. This will help users not need to search very hard for non-docker driver options and help users get right into what driver choices are available.
Let me know if there is any information missing or if there are supplementary pieces to add to the
Requires an ISO that supports arm64
comments for parallels/vmware.