-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Addon] Kong Ingress Controller #13326
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @gAmUssA! |
Hi @gAmUssA. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
@k8s-ci-robot /check-cla |
/assign @afbjorklund |
Hey @gAmUssA, thanks for the PR! Could you templatize the images in the yaml and add the pinned references to pkg/minikube/assets/addons.go? See https://github.com/kubernetes/minikube/blob/master/deploy/addons/gcp-auth/gcp-auth-webhook.yaml.tmpl#L131 and https://github.com/kubernetes/minikube/blob/master/pkg/minikube/assets/addons.go#L541 for an example on how it's done. |
fieldRef: | ||
apiVersion: v1 | ||
fieldPath: metadata.namespace | ||
image: kong/kubernetes-ingress-controller:2.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this PR,
would u plz add the image sha to the image name, to ensure the integrity of this image
Team, @medyagh @sharifelgamal |
Team |
@gAmUssA sorry for the delay, do u mind adding a doc page on this our website of how to use this add-on ? and would u plz add example usage of this addon to the PR description ? and what it is used for ? |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 48.8s 45.1s 43.9s 44.2s 45.0s Times for minikube ingress: 28.6s 25.6s 30.1s 30.5s 29.0s docker driver with docker runtime
Times for minikube ingress: 21.9s 25.4s 23.0s 23.4s 22.9s Times for minikube start: 29.4s 26.7s 26.2s 26.8s 24.8s docker driver with containerd runtime
Times for minikube start: 32.6s 45.4s 41.5s 45.0s 41.3s Times for minikube ingress: 23.4s 18.9s 23.4s 18.9s 23.4s |
kvm2 driver with docker runtime
Times for minikube start: 46.2s 44.8s 45.7s 50.1s 43.2s Times for minikube ingress: 29.1s 25.5s 29.1s 29.1s 29.1s docker driver with docker runtime
Times for minikube start: 26.1s 29.2s 26.9s 25.2s 25.9s Times for minikube ingress: 21.9s 21.9s 21.9s 21.9s 22.4s docker driver with containerd runtime
Times for minikube start: 45.4s 46.0s 41.3s 41.2s 40.7s Times for minikube (PR 13326) ingress: 19.9s 19.4s 23.9s 18.9s 23.4s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
@medyagh Let me know if there is something missing from my side. Thank you |
dear @medyagh @sharifelgamal @afbjorklund |
/ok-to-test |
I'm going to rerun our integration test suite, and if everything looks good, this PR should be good to merge. |
kvm2 driver with docker runtime
Times for minikube (PR 13326) ingress: 31.6s 30.0s 46.6s 29.1s 31.1s Times for minikube start: 45.8s 45.5s 44.7s 45.1s 45.4s docker driver with docker runtime
Times for minikube (PR 13326) start: 25.7s 25.2s 25.6s 26.2s 25.2s Times for minikube ingress: 28.4s 28.4s 23.9s 22.9s 24.9s docker driver with containerd runtime
Times for minikube start: 30.9s 42.3s 42.0s 41.7s 45.1s Times for minikube ingress: 27.4s 46.4s 26.9s 25.4s 20.0s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gAmUssA, sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for contributing to minikube! |
A new addon for Kong Ingress Controller (KIC) https://github.com/Kong/kubernetes-ingress-controller.
Kong Ingress Controller works inside a Kubernetes cluster and configures Kong to proxy traffic as per rules defined in the
Ingress resources. This addon enables KIC for local development and testing of services that require Ingress object.