mount: fix Bad file descriptor
#13013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
approved
|
kvm2 driver with docker runtime Times for minikube start: 48.9s 45.2s 45.5s 46.1s 45.7s Times for minikube ingress: 30.2s 31.3s 32.2s 29.7s 32.3s docker driver with docker runtime Times for minikube start: 22.6s 21.9s 22.9s 21.5s 21.3s Times for minikube ingress: 26.9s 33.9s 33.4s 25.9s 81.4s docker driver with containerd runtime Times for minikube ingress: 32.9s 22.4s 31.9s 32.4s 32.4s Times for minikube start: 30.1s 40.8s 39.9s 40.8s 41.9s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
k8s-ci-robot
added
size/XS
|
kvm2 driver with docker runtime Times for minikube start: 49.8s 46.9s 45.7s 46.8s 47.5s Times for minikube ingress: 30.3s 29.7s 31.7s 32.2s 29.8s docker driver with docker runtime Times for minikube start: 22.1s 20.4s 20.5s 20.2s 20.3s Times for minikube ingress: 25.5s 24.9s 26.9s 27.4s 25.9s docker driver with containerd runtime Times for minikube start: 27.9s 40.6s 40.8s 36.0s 40.9s Times for minikube (PR 13013) ingress: 21.4s 18.5s 27.0s 27.4s 17.9s |
spowelljr
changed the title
Bad file descriptor
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
medyagh
approved these changes
Nov 23, 2021
|
nice ! thank you for fixing this annoying bug |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
blt
added a commit
to vectordotdev/vector
that referenced
this pull request
Nov 23, 2021
It turns out that the problem discussed in the last commit is fixed by kubernetes/minikube#13013. This is not present in a minikube release yet, so we can't rely on it. That said, this commit introduces a hack whereby the bootstrap is passed in a configmap. This limits the size of the bootstrap with all the problems that come along with a low-entropy experiment. Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt
added a commit
to vectordotdev/vector
that referenced
this pull request
Nov 24, 2021
* Introduce a new http -> pipelines -> blackhole soak This commit introduces a new soak to investigate our pipelines in an ongoing basis. The pipeline configuration for vector and the sample data was contributed by work was contributed @vladimir-dd. I have expanded the soak to allow mounting a TESTNAME/data to smuggle static data into the minikube, by which we feed http_gen. Unfortunately this does not work as we cannot use the Virtual Box VM for soak testing and kubernetes/minikube#12301 is open. We will have to figure out some other way to smuggle data into the minikube for this soak to function. This commit depends on #10141 which depends on DataDog/lading#119. Signed-off-by: Brian L. Troutwine <brian@troutwine.us> * Use configmap hack It turns out that the problem discussed in the last commit is fixed by kubernetes/minikube#13013. This is not present in a minikube release yet, so we can't rely on it. That said, this commit introduces a hack whereby the bootstrap is passed in a configmap. This limits the size of the bootstrap with all the problems that come along with a low-entropy experiment. Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12301
Removed the
if fid.openedthenreq.RespondError(Ebaduse), the comment for the statement is/* we can't walk open files */, but when the check is skipped we can walk the supposedly open files fine, so I feel confident we can skip this check.