Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump golint version #12885

Merged
merged 2 commits into from
Nov 9, 2021
Merged

bump golint version #12885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09328fd
bump golaint versions
minikube-bot Nov 8, 2021
69aa495
address lint concerns
spowelljr Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ MINIKUBE_RELEASES_URL=https://github.com/kubernetes/minikube/releases/download
KERNEL_VERSION ?= 4.19.202
# latest from https://github.com/golangci/golangci-lint/releases
# update this only by running `make update-golint-version`
GOLINT_VERSION ?= v1.42.1
GOLINT_VERSION ?= v1.43.0
# Limit number of default jobs, to avoid the CI builds running out of memory
GOLINT_JOBS ?= 4
# see https://github.com/golangci/golangci-lint#memory-usage-of-golangci-lint
Expand Down
4 changes: 2 additions & 2 deletions pkg/minikube/bootstrapper/bsutil/kubeadm_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,10 @@ func recentReleases(n int) ([]string, error) {
foundDefault := false

for _, v := range versions {
if strings.HasPrefix(constants.NewestKubernetesVersion, v) {
if strings.HasPrefix(constants.NewestKubernetesVersion, v) { //nolint:gocritic // Complains "constants.NewestKubernetesVersion and v arguments order looks reversed"
foundNewest = true
}
if strings.HasPrefix(constants.DefaultKubernetesVersion, v) {
if strings.HasPrefix(constants.DefaultKubernetesVersion, v) { //nolint:gocritic // Same as above
foundDefault = true
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/integration/driver_install_or_update_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ func prepareTempMinikubeDirWithHyperkitDriver(name, driver string) (string, stri
}

// try to copy cached files to the temp minikube folder to avoid downloading of iso and preloads
_ = CopyDir(filepath.Join(localpath.MakeMiniPath("cache")), filepath.Join(mkDir, "cache"))
_ = CopyDir(localpath.MakeMiniPath("cache"), filepath.Join(mkDir, "cache"))

// change permission to allow driver to be executable
if err = os.Chmod(testDriverPath, 0755); err != nil {
Expand Down