Support starting minikube with the Podman driver on NixOS systems #12739

alias-dev · 2021-10-19T19:57:11Z

Checks both the standard kernel modules path at /lib/modules, and the /run/current-system/kernel-modules/lib/modules path present on NixOS systems before mounting.

fixes #12738

k8s-ci-robot · 2021-10-19T19:57:18Z

Welcome @alias-dev!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-10-19T19:57:19Z

Hi @alias-dev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2021-10-19T19:59:04Z

Can one of the admins verify this patch?

medyagh · 2021-10-19T23:01:08Z

/ok-to-test

medyagh · 2021-10-19T23:02:09Z

very interesting PR ! thanks you @alias-dev do u mind sharing an example of NixOS system error before and after this PR ? since I can not verify this myself

minikube-pr-bot · 2021-10-20T00:09:39Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 46.7s    | 46.8s               |
| enable ingress | 31.6s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube start: 49.1s 45.9s 45.5s 46.4s 46.8s
Times for minikube (PR 12739) start: 48.0s 46.7s 45.9s 46.9s 46.7s

Times for minikube (PR 12739) ingress: 31.7s 32.2s 30.7s 30.8s 31.3s
Times for minikube ingress: 31.2s 31.8s 32.3s 31.3s 31.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.2s               |
| enable ingress | 26.7s    | 28.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 25.9s 26.9s 26.9s 26.4s 27.4s
Times for minikube (PR 12739) ingress: 26.4s 34.4s 26.9s 27.4s 25.9s

Times for minikube (PR 12739) start: 20.6s 21.5s 21.6s 20.7s 21.8s
Times for minikube start: 22.7s 21.0s 22.1s 21.1s 20.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 38.0s    | 40.6s               |
| enable ingress | 32.6s    | 37.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 12739) start: 29.0s 43.4s 42.9s 44.2s 43.6s
Times for minikube start: 31.3s 42.3s 36.9s 43.1s 36.2s

Times for minikube (PR 12739) ingress: 30.4s 32.9s 26.9s 32.9s 61.9s
Times for minikube ingress: 28.4s 32.9s 33.1s 32.9s 35.5s

minikube-pr-bot · 2021-10-20T00:35:07Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux_containerd	TestAddons/serial/GCPAuth (gopogh)	2.60 (chart)
Docker_Linux	TestAddons/serial/GCPAuth (gopogh)	2.61 (chart)
KVM_Linux	TestAddons/serial/GCPAuth (gopogh)	2.61 (chart)
Docker_Linux_containerd	TestAddons/serial/GCPAuth (gopogh)	2.63 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/Pause (gopogh)	2.63 (chart)
Docker_Linux_containerd	TestFunctional/serial/LogsFileCmd (gopogh)	7.89 (chart)
Docker_Linux_containerd	TestPause/serial/PauseAgain (gopogh)	24.34 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

alias-dev · 2021-10-20T07:37:48Z

Thanks @medyagh. Without this change we get a statfs /lib/modules: no such file or directory error:

* minikube v1.23.2 on Nixos 21.11 (Porcupine)
  - MINIKUBE_IN_STYLE=0
* Using the podman driver based on user configuration
* Starting control plane node minikube in cluster minikube
* Pulling base image ...
E1020 08:29:40.440737  759136 cache.go:201] Error downloading kic artifacts:  not yet implemented, see issue #8426
* Creating podman container (CPUs=2, Memory=2200MB) ...
! StartHost failed, but will try again: creating host: create: creating: create kic node: create container: sudo -n podman run --cgroup-manager cgroupfs -d -t --privileged --device /dev/fuse --security-opt seccomp=unconfined --tmpfs /tmp --tmpfs /run -v /lib/modules:/lib/modules:ro --hostname minikube --name minikube --label created_by.minikube.sigs.k8s.io=true --label name.minikube.sigs.k8s.io=minikube --label role.minikube.sigs.k8s.io= --label mode.minikube.sigs.k8s.io=minikube --network minikube --ip 192.168.49.2 --volume minikube:/var:exec -e container=podman --expose 8443 --publish=127.0.0.1::8443 --publish=127.0.0.1::22 --publish=127.0.0.1::2376 --publish=127.0.0.1::5000 --publish=127.0.0.1::32443 gcr.io/k8s-minikube/kicbase:v0.0.27: exit status 125
stdout:

stderr:
Error: statfs /lib/modules: no such file or directory

* Restarting existing podman container for "minikube" ...
* Failed to start podman container. Running "minikube delete" may fix it: podman inspect ip minikube: sudo -n podman container inspect -f {{.NetworkSettings.IPAddress}} minikube: exit status 125
stdout:

stderr:
Error: error inspecting object: no such container minikube


X Exiting due to GUEST_PROVISION: Failed to start host: podman inspect ip minikube: sudo -n podman container inspect -f  minikube: exit status 125
stdout:

stderr:
Error: error inspecting object: no such container minikube

And with it, the /run/current-system/kernel-modules/lib/modules path is found and mounted successfully:

* minikube v0.0.0-unset on Nixos 21.11 (Porcupine)
  - MINIKUBE_IN_STYLE=0
* Using the podman driver based on user configuration
* Starting control plane node minikube in cluster minikube
* Pulling base image ...
E1020 08:32:38.110214  764453 cache.go:201] Error downloading kic artifacts:  not yet implemented, see issue #8426
* Creating podman container (CPUs=2, Memory=2200MB) ...
* Preparing Kubernetes v1.22.2 on CRI-O 1.22.0 ...
X Unable to load cached images: loading cached images: removing image: crictl: sudo /usr/bin/crictl rmi gcr.io/k8s-minikube/storage-provisioner:: Process exited with status 1
stdout:

stderr:
time="2021-10-20T07:32:55Z" level=error msg="image status request for \"gcr.io/k8s-minikube/storage-provisioner:\" failed: rpc error: code = Unknown desc = invalid reference format"
time="2021-10-20T07:32:55Z" level=fatal msg="unable to remove the image(s)"

  - Generating certificates and keys ...
  - Booting up control plane ...
  - Configuring RBAC rules ...
* Configuring CNI (Container Networking Interface) ...
* Verifying Kubernetes components...
  - Using image gcr.io/k8s-minikube/storage-provisioner:
! Enabling 'storage-provisioner' returned an error: running callbacks: [sudo KUBECONFIG=/var/lib/minikube/kubeconfig /var/lib/minikube/binaries/v1.22.2/kubectl apply -f /etc/kubernetes/addons/storage-provisioner.yaml: Process exited with status 1
stdout:
serviceaccount/storage-provisioner unchanged
clusterrolebinding.rbac.authorization.k8s.io/storage-provisioner unchanged
role.rbac.authorization.k8s.io/system:persistent-volume-provisioner unchanged
rolebinding.rbac.authorization.k8s.io/system:persistent-volume-provisioner unchanged
endpoints/k8s.io-minikube-hostpath unchanged

stderr:
error: error parsing /etc/kubernetes/addons/storage-provisioner.yaml: error converting YAML to JSON: yaml: line 14: mapping values are not allowed in this context
]
* Enabled addons: default-storageclass
* Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

The error with the storage provisioner is due to the manifest being generated without an image tag, so I don't think that's related to this change:

#  /etc/kubernetes/addons/storage-provisioner.yaml
...
---
apiVersion: v1
kind: Pod
metadata:
  name: storage-provisioner
  namespace: kube-system
  labels:
    integration-test: storage-provisioner
    addonmanager.kubernetes.io/mode: Reconcile
spec:
  serviceAccountName: storage-provisioner
  hostNetwork: true
  containers:
  - name: storage-provisioner
    image: gcr.io/k8s-minikube/storage-provisioner:
    command: ["/storage-provisioner"]
    imagePullPolicy: IfNotPresent
    volumeMounts:
    - mountPath: /tmp
      name: tmp
  volumes:
  - name: tmp
    hostPath:
      path: /tmp
      type: Directory

medyagh · 2021-10-20T17:27:33Z

provisioner is due to the manifest being generated without an image tag, so I don't think that's related to this change:

does the provsioner error happen even if u do a minikube delete --all before starting?

medyagh · 2021-10-20T17:29:33Z

please also fix the lint issues in https://github.com/kubernetes/minikube/pull/12739/checks?check_run_id=3945413490

medyagh · 2021-10-20T17:44:46Z

btw this is the line in our code that generates storage provisioner:

deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl

    image: {{.CustomRegistries.StorageProvisioner  | default .ImageRepository | default .Registries.StorageProvisioner }}{{.Images.StorageProvisioner}}

maybe we should fix it in a way that if there is no Tag, it should not have the the ":"
or figure out the reason why the Tag is missing ? was it on a second start? maybe on a second start this happens?

alias-dev · 2021-10-20T17:59:33Z

@medyagh My mistake! I'd built it with go build instead of the make target, so storageProvisionerVersion wasn't populated in version.go:

minikube/pkg/version/version.go

Line 37 in 038effb

    
           // storageProvisionerVersion is a private field and should be set when compiling with --ldflags="-X k8s.io/minikube/pkg/version.storageProvisionerVersion=<storage-provisioner-version>"

Building with the make target, it now runs OK:

* minikube v1.23.2 on Nixos 21.11 (Porcupine)
  - MINIKUBE_IN_STYLE=0
* Using the podman driver based on user configuration
* Starting control plane node minikube in cluster minikube
* Pulling base image ...
E1020 18:53:13.195251 1206356 cache.go:201] Error downloading kic artifacts:  not yet implemented, see issue #8426
* Creating podman container (CPUs=2, Memory=2200MB) ...
* Preparing Kubernetes v1.22.2 on CRI-O 1.22.0 ...
  - Generating certificates and keys ...
  - Booting up control plane ...
  - Configuring RBAC rules ...
* Configuring CNI (Container Networking Interface) ...
* Verifying Kubernetes components...
  - Using image gcr.io/k8s-minikube/storage-provisioner:v5
* Enabled addons: storage-provisioner, default-storageclass
* Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

alias-dev · 2021-10-20T18:18:15Z

@medyagh Regarding the lint error, it seems I've just nudged that function over the complexity threshold. I had considered a simpler implementation of this using a KERNEL_MODULES_PATH environment variable if set, would that be preferable?

medyagh · 2021-10-25T22:13:16Z

@medyagh Regarding the lint error, it seems I've just nudged that function over the complexity threshold. I had considered a simpler implementation of this using a KERNEL_MODULES_PATH environment variable if set, would that be preferable?

yes letsfix the lint !or could move the implementation details into helper func.

minikube-pr-bot · 2021-11-17T20:26:00Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 48.6s    | 47.7s               |
| enable ingress | 31.3s    | 32.4s               |
+----------------+----------+---------------------+

Times for minikube start: 50.8s 47.4s 48.3s 47.1s 49.3s
Times for minikube (PR 12739) start: 48.5s 47.8s 46.3s 47.7s 48.2s

Times for minikube ingress: 32.4s 30.9s 31.3s 31.4s 30.8s
Times for minikube (PR 12739) ingress: 31.3s 31.8s 33.9s 32.4s 32.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 22.5s               |
| enable ingress | 28.2s    | 28.1s               |
+----------------+----------+---------------------+

Times for minikube start: 22.8s 22.1s 22.2s 22.2s 22.6s
Times for minikube (PR 12739) start: 21.5s 23.4s 22.3s 22.2s 23.0s

Times for minikube ingress: 26.0s 27.0s 26.5s 34.0s 27.5s
Times for minikube (PR 12739) ingress: 27.4s 26.5s 34.0s 26.5s 26.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 38.5s    | 35.3s               |
| enable ingress | 37.0s    | 36.8s               |
+----------------+----------+---------------------+

Times for minikube start: 25.1s 41.7s 41.1s 42.4s 42.2s
Times for minikube (PR 12739) start: 25.8s 25.7s 40.7s 42.9s 41.2s

Times for minikube (PR 12739) ingress: 61.5s 32.5s 28.5s 32.4s 28.9s
Times for minikube ingress: 41.4s 26.9s 57.4s 31.5s 27.9s

minikube-pr-bot · 2021-11-17T21:59:55Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestFunctional/parallel/ServiceCmd (gopogh)	n/a
Docker_macOS	TestAddons/Setup (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/CertSync (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/CpCmd (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/DockerEnv/bash (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/FileSync (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/NodeLabels (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/SSHCmd (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/StatusCmd (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/Version/components (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/AuditLog (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/KubeContext (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/KubectlGetPods (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/LogsCmd (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/LogsFileCmd (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/MinikubeKubectlCmd (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/MinikubeKubectlCmdDirectly (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/SoftStart (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/StartWithProxy (gopogh)	0.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	0.00 (chart)
Docker_macOS	TestJSONOutput/pause/Audit (gopogh)	0.00 (chart)
Docker_macOS	TestJSONOutput/start/Audit (gopogh)	0.00 (chart)
Docker_macOS	TestJSONOutput/start/Command (gopogh)	0.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-11-17T22:58:05Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 48.4s    | 48.2s               |
| enable ingress | 32.3s    | 32.1s               |
+----------------+----------+---------------------+

Times for minikube start: 50.8s 47.1s 49.1s 48.4s 46.8s
Times for minikube (PR 12739) start: 47.5s 48.8s 47.7s 47.7s 49.1s

Times for minikube (PR 12739) ingress: 31.9s 32.3s 31.9s 32.3s 32.4s
Times for minikube ingress: 31.8s 33.3s 32.3s 32.3s 31.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 22.6s               |
| enable ingress | 29.4s    | 28.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 12739) start: 22.4s 22.7s 21.9s 22.2s 23.8s
Times for minikube start: 23.4s 22.3s 21.8s 22.5s 23.0s

Times for minikube ingress: 29.0s 27.5s 27.5s 35.5s 27.5s
Times for minikube (PR 12739) ingress: 28.5s 27.4s 29.5s 28.0s 31.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 34.4s    | 39.6s               |
| enable ingress | 32.3s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube start: 25.4s 25.8s 42.0s 36.9s 41.9s
Times for minikube (PR 12739) start: 41.2s 36.4s 42.4s 41.2s 36.6s

Times for minikube ingress: 32.9s 34.4s 32.5s 28.8s 32.9s
Times for minikube (PR 12739) ingress: 33.5s 24.4s 20.0s 32.9s 24.7s

alias-dev · 2021-11-17T23:12:30Z

@medyagh Sorry it took me a while to come back to this. Is this looking OK now?

minikube-pr-bot · 2021-11-18T00:04:24Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 47.2s               |
| enable ingress | 31.5s    | 31.6s               |
+----------------+----------+---------------------+

Times for minikube start: 49.7s 47.2s 47.2s 46.7s 47.9s
Times for minikube (PR 12739) start: 49.0s 47.0s 46.9s 46.8s 46.5s

Times for minikube ingress: 31.8s 31.3s 31.3s 31.3s 31.8s
Times for minikube (PR 12739) ingress: 32.3s 31.3s 31.2s 31.3s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 21.6s               |
| enable ingress | 31.0s    | 29.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.4s 26.9s 35.4s 27.4s 34.0s
Times for minikube (PR 12739) ingress: 31.4s 26.9s 33.5s 27.4s 27.0s

Times for minikube (PR 12739) start: 20.8s 21.6s 21.4s 22.1s 21.9s
Times for minikube start: 22.4s 21.3s 21.7s 20.9s 21.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 36.8s    | 39.9s               |
| enable ingress | 29.0s    | 28.1s               |
+----------------+----------+---------------------+

Times for minikube start: 29.5s 41.3s 42.3s 41.4s 29.7s
Times for minikube (PR 12739) start: 41.7s 41.2s 40.7s 35.6s 40.4s

Times for minikube ingress: 32.4s 32.9s 18.9s 32.9s 28.0s
Times for minikube (PR 12739) ingress: 32.9s 32.4s 32.9s 25.4s 16.9s

minikube-pr-bot · 2021-11-18T00:41:46Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestFunctional/parallel/ServiceCmd (gopogh)	n/a
Docker_Windows	TestFunctional/parallel/ServiceCmd (gopogh)	n/a
Docker_Windows	TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh)	n/a
Docker_Linux	TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
Docker_Linux	TestStartStop/group/no-preload/serial/SecondStart (gopogh)	0.00 (chart)
Docker_Linux	TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
Docker_Linux	TestStartStop/group/no-preload/serial/VerifyKubernetesImages (gopogh)	0.00 (chart)
Docker_macOS	TestAddons/Setup (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/CertSync (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/CpCmd (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/DockerEnv/bash (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/FileSync (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/NodeLabels (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/SSHCmd (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/StatusCmd (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/Version/components (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/AuditLog (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/KubeContext (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/KubectlGetPods (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/LogsCmd (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/LogsFileCmd (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/MinikubeKubectlCmd (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/MinikubeKubectlCmdDirectly (gopogh)	0.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-11-18T01:14:37Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux	TestStartStop/group/newest-cni/serial/SecondStart (gopogh)	1.81 (chart)
Docker_Linux	TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh)	1.81 (chart)
Docker_Linux	TestStartStop/group/newest-cni/serial/Pause (gopogh)	4.82 (chart)
Docker_macOS	TestCertOptions (gopogh)	6.80 (chart)
Docker_macOS	TestDockerFlags (gopogh)	6.80 (chart)
Docker_macOS	TestForceSystemdEnv (gopogh)	6.80 (chart)
Docker_macOS	TestForceSystemdFlag (gopogh)	6.80 (chart)
Hyperkit_macOS	TestFunctional/serial/CacheCmd/cache/add_remote (gopogh)	8.00 (chart)
Hyperkit_macOS	TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh)	8.00 (chart)
Hyperkit_macOS	TestFunctional/serial/CacheCmd/cache/delete (gopogh)	8.00 (chart)
Hyperkit_macOS	TestFunctional/serial/CacheCmd/cache/delete_k8s.gcr.io/pause (gopogh)	3.3 (chart)
Hyperkit_macOS	TestFunctional/serial/CacheCmd/cache/list (gopogh)	8.00 (chart)
Hyperkit_macOS	TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh)	8.00 (chart)
KVM_Linux_containerd	TestFunctional/serial/CacheCmd/cache/add_remote (gopogh)	8.38 (chart)
KVM_Linux_containerd	TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh)	8.38 (chart)
KVM_Linux_containerd	TestFunctional/serial/CacheCmd/cache/delete (gopogh)	8.38 (chart)
KVM_Linux_containerd	TestFunctional/serial/CacheCmd/cache/delete_k8s.gcr.io/pause (gopogh)	3.3 (chart)
KVM_Linux_containerd	TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh)	8.38 (chart)
KVM_Linux_containerd	TestStartStop/group/no-preload/serial/VerifyKubernetesImages (gopogh)	8.38 (chart)
Hyperkit_macOS	TestStartStop/group/no-preload/serial/VerifyKubernetesImages (gopogh)	8.40 (chart)
Docker_Linux_containerd	TestFunctional/serial/CacheCmd/cache/add_remote (gopogh)	8.43 (chart)
Docker_Linux_containerd	TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh)	8.43 (chart)
Docker_Linux_containerd	TestFunctional/serial/CacheCmd/cache/delete (gopogh)	8.43 (chart)
Docker_Linux_containerd	TestFunctional/serial/CacheCmd/cache/delete_k8s.gcr.io/pause (gopogh)	3.3 (chart)
Docker_Linux_containerd	TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh)	8.43 (chart)
Docker_Linux	TestFunctional/serial/CacheCmd/cache/add_remote (gopogh)	8.43 (chart)
Docker_Linux	TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh)	8.43 (chart)
Docker_Linux	TestFunctional/serial/CacheCmd/cache/delete (gopogh)	8.43 (chart)
Docker_Linux	TestFunctional/serial/CacheCmd/cache/delete_k8s.gcr.io/pause (gopogh)	3.3 (chart)
Docker_Linux	TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh)	8.43 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

arthurk · 2021-12-31T05:11:06Z

I ran into the same problem today with minikube v1.24.0 on NixOS 21.11. Is there anything missing from this PR? Maybe I can help

minikube-pr-bot · 2021-12-31T10:13:41Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 44.5s    | 44.9s               |
| enable ingress | 27.7s    | 27.8s               |
+----------------+----------+---------------------+

Times for minikube start: 46.0s 44.3s 44.7s 43.6s 44.0s
Times for minikube (PR 12739) start: 45.5s 45.2s 44.6s 45.0s 44.2s

Times for minikube ingress: 26.1s 26.5s 28.6s 28.6s 28.6s
Times for minikube (PR 12739) ingress: 29.5s 25.6s 29.0s 29.1s 25.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 26.9s    | 25.5s               |
| enable ingress | 22.4s    | 22.6s               |
+----------------+----------+---------------------+

Times for minikube start: 29.7s 26.3s 26.3s 25.8s 26.4s
Times for minikube (PR 12739) start: 25.5s 26.0s 26.0s 25.3s 24.9s

Times for minikube ingress: 22.9s 22.0s 21.9s 23.4s 21.9s
Times for minikube (PR 12739) ingress: 23.4s 22.9s 21.9s 22.9s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 41.6s    | 42.1s               |
| enable ingress | 20.8s    | 28.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 19.9s 22.9s 18.9s 22.9s 19.4s
Times for minikube (PR 12739) ingress: 18.9s 23.4s 23.4s 23.4s 53.4s

Times for minikube start: 34.2s 41.4s 45.2s 41.4s 45.6s
Times for minikube (PR 12739) start: 45.1s 41.8s 41.2s 41.3s 40.9s

minikube-pr-bot · 2021-12-31T12:07:12Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux	TestNetworkPlugins/group/custom-weave/Start (gopogh)	2.04 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/Start (gopogh)	2.72 (chart)
Docker_Windows	TestDockerFlags (gopogh)	7.27 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh)	12.26 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh)	12.26 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh)	12.26 (chart)
Docker_Windows	TestPause/serial/PauseAgain (gopogh)	12.50 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh)	13.89 (chart)
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	19.28 (chart)
Docker_Windows	TestNetworkPlugins/group/auto/DNS (gopogh)	20.62 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	24.53 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	25.23 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	25.47 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	25.47 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	25.47 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	26.17 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh)	27.52 (chart)
Docker_macOS	TestNoKubernetes/serial/Start (gopogh)	27.69 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	28.18 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	28.30 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	28.30 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	29.09 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh)	36.45 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh)	37.04 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh)	37.74 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh)	38.32 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh)	38.32 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	38.68 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/kindnet/Start (gopogh)	39.52 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/Pause (gopogh)	42.59 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

klaases · 2022-01-25T21:16:19Z

Hi @medyagh, do you think this PR is ready to merge?

k8s-triage-robot · 2022-04-25T22:11:57Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

minikube-pr-bot · 2022-05-12T23:49:42Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 50.8s               |
| enable ingress | 28.2s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.1s 29.1s 26.1s 26.5s 30.1s
Times for minikube (PR 12739) ingress: 26.5s 29.0s 29.0s 29.6s 28.1s

Times for minikube (PR 12739) start: 50.5s 51.6s 50.0s 51.5s 50.2s
Times for minikube start: 52.2s 49.9s 50.1s 51.6s 50.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 25.2s    | 25.0s               |
| enable ingress | 22.8s    | 22.7s               |
+----------------+----------+---------------------+

Times for minikube start: 28.7s 23.9s 24.6s 23.8s 24.8s
Times for minikube (PR 12739) start: 25.5s 25.6s 24.2s 24.5s 25.2s

Times for minikube ingress: 22.9s 22.4s 23.0s 22.9s 23.0s
Times for minikube (PR 12739) ingress: 22.9s 21.9s 22.4s 22.4s 23.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 30.7s    | 30.8s               |
| enable ingress | 22.9s    | 25.0s               |
+----------------+----------+---------------------+

Times for minikube start: 34.9s 28.9s 28.4s 29.1s 32.3s
Times for minikube (PR 12739) start: 34.4s 29.1s 29.8s 32.0s 29.0s

Times for minikube ingress: 18.9s 32.4s 22.4s 21.9s 18.9s
Times for minikube (PR 12739) ingress: 27.9s 22.4s 23.4s 28.9s 22.4s

minikube-pr-bot · 2022-05-13T01:13:46Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux	TestStartStop/group/embed-certs/serial/Pause (gopogh)	0.00 (chart)
Hyperkit_macOS	TestJSONOutput/start/Audit (gopogh)	0.00 (chart)
Hyperkit_macOS	TestJSONOutput/start/Command (gopogh)	0.00 (chart)
Hyperkit_macOS	TestNetworkPlugins/group/flannel/Start (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestAddons/Setup (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Audit (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Command (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestMultiNode/serial/AddNode (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestMultiNode/serial/DeleteNode (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestMultiNode/serial/FreshStart2Nodes (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestMultiNode/serial/ProfileList (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartKeepsNodes (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartMultiNode (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StartAfterStop (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StopNode (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestPreload (gopogh)	23.89 (chart)
Docker_Linux_containerd	TestOffline (gopogh)	27.43 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MountCmd/any-port (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MySQL (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmd (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmdConnect (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/serial/ExtraConfig (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/serial/SoftStart (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/serial/StartWithProxy (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestMultiNode/serial/DeployApp2Nodes (gopogh)	37.17 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2022-05-16T22:24:06Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 50.7s    | 51.2s               |
| enable ingress | 28.9s    | 27.6s               |
+----------------+----------+---------------------+

Times for minikube start: 52.2s 50.6s 50.4s 51.3s 49.1s
Times for minikube (PR 12739) start: 50.2s 51.6s 51.6s 51.2s 51.5s

Times for minikube ingress: 29.1s 29.6s 30.1s 25.1s 30.6s
Times for minikube (PR 12739) ingress: 26.0s 28.6s 26.1s 28.6s 28.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 25.3s    | 24.4s               |
| enable ingress | 23.3s    | 22.5s               |
+----------------+----------+---------------------+

Times for minikube start: 28.4s 23.9s 24.3s 24.8s 25.2s
Times for minikube (PR 12739) start: 23.9s 25.0s 24.4s 24.9s 23.6s

Times for minikube (PR 12739) ingress: 21.4s 21.9s 23.9s 22.4s 22.9s
Times for minikube ingress: 23.9s 23.0s 22.4s 22.9s 24.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12739) |
+----------------+----------+---------------------+
| minikube start | 30.2s    | 32.4s               |
| enable ingress | 25.3s    | 23.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.4s 17.9s 31.9s 31.9s 22.4s
Times for minikube (PR 12739) ingress: 22.4s 27.9s 19.9s 22.4s 23.4s

Times for minikube start: 30.1s 34.0s 28.6s 29.4s 28.7s
Times for minikube (PR 12739) start: 28.7s 32.6s 32.3s 28.5s 39.9s

minikube-pr-bot · 2022-05-17T00:52:15Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestNetworkPlugins/group/cilium/Start (gopogh)	6.17 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/auto/DNS (gopogh)	16.05 (chart)
Docker_Linux_containerd	TestAddons/parallel/Registry (gopogh)	17.44 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/custom-weave/Start (gopogh)	23.46 (chart)
Docker_Linux_containerd	TestOffline (gopogh)	27.43 (chart)
Docker_Linux_containerd	TestPause/serial/Start (gopogh)	27.43 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	36.96 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MountCmd/any-port (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MySQL (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmd (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmdConnect (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/serial/ExtraConfig (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/serial/SoftStart (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/serial/StartWithProxy (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestMultiNode/serial/DeployApp2Nodes (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	37.17 (chart)
Docker_Linux_containerd	TestFunctional/parallel/DashboardCmd (gopogh)	38.05 (chart)
Docker_Linux	TestNetworkPlugins/group/false/DNS (gopogh)	39.00 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	44.57 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	46.74 (chart)
Docker_Windows	TestAddons/Setup (gopogh)	48.57 (chart)
Docker_Windows	TestFunctional/parallel/CertSync (gopogh)	48.57 (chart)
Docker_Windows	TestFunctional/parallel/CpCmd (gopogh)	48.57 (chart)
Docker_Windows	TestFunctional/parallel/DockerEnv/powershell (gopogh)	48.57 (chart)
Docker_Windows	TestFunctional/parallel/FileSync (gopogh)	48.57 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageBuild (gopogh)	48.57 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageListJson (gopogh)	48.57 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

spowelljr

Thanks for the PR @alias-dev!

k8s-ci-robot · 2022-06-07T23:30:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, alias-dev, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 19, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 19, 2021

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 19, 2021

k8s-ci-robot requested review from afbjorklund and prasadkatti October 19, 2021 19:57

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 19, 2021

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 17, 2021

afbjorklund approved these changes Jan 23, 2022

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2022

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 11, 2022

alias-dev added 3 commits May 16, 2022 22:30

fix NixOS kernel modules path in podman driver

8fb9165

move checkRunning out of CreateContainerNode

e5d8c9d

return default kernel modules path if alternatives are not found

1d35e4f

spowelljr approved these changes Jun 7, 2022

View reviewed changes

spowelljr merged commit 2f3a851 into kubernetes:master Jun 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support starting minikube with the Podman driver on NixOS systems #12739

Support starting minikube with the Podman driver on NixOS systems #12739

alias-dev commented Oct 19, 2021

k8s-ci-robot commented Oct 19, 2021

k8s-ci-robot commented Oct 19, 2021

minikube-bot commented Oct 19, 2021

medyagh commented Oct 19, 2021

medyagh commented Oct 19, 2021

minikube-pr-bot commented Oct 20, 2021

minikube-pr-bot commented Oct 20, 2021

alias-dev commented Oct 20, 2021 •

edited

Loading

medyagh commented Oct 20, 2021

medyagh commented Oct 20, 2021

medyagh commented Oct 20, 2021

alias-dev commented Oct 20, 2021

alias-dev commented Oct 20, 2021

medyagh commented Oct 25, 2021

minikube-pr-bot commented Nov 17, 2021

minikube-pr-bot commented Nov 17, 2021

minikube-pr-bot commented Nov 17, 2021

alias-dev commented Nov 17, 2021

minikube-pr-bot commented Nov 18, 2021

minikube-pr-bot commented Nov 18, 2021

minikube-pr-bot commented Nov 18, 2021

arthurk commented Dec 31, 2021

minikube-pr-bot commented Dec 31, 2021

minikube-pr-bot commented Dec 31, 2021

klaases commented Jan 25, 2022

k8s-triage-robot commented Apr 25, 2022

minikube-pr-bot commented May 12, 2022

minikube-pr-bot commented May 13, 2022

minikube-pr-bot commented May 16, 2022

minikube-pr-bot commented May 17, 2022

spowelljr left a comment

k8s-ci-robot commented Jun 7, 2022

Support starting minikube with the Podman driver on NixOS systems #12739

Support starting minikube with the Podman driver on NixOS systems #12739

Conversation

alias-dev commented Oct 19, 2021

k8s-ci-robot commented Oct 19, 2021

k8s-ci-robot commented Oct 19, 2021

minikube-bot commented Oct 19, 2021

medyagh commented Oct 19, 2021

medyagh commented Oct 19, 2021

minikube-pr-bot commented Oct 20, 2021

minikube-pr-bot commented Oct 20, 2021

alias-dev commented Oct 20, 2021 • edited Loading

medyagh commented Oct 20, 2021

medyagh commented Oct 20, 2021

medyagh commented Oct 20, 2021

alias-dev commented Oct 20, 2021

alias-dev commented Oct 20, 2021

medyagh commented Oct 25, 2021

minikube-pr-bot commented Nov 17, 2021

minikube-pr-bot commented Nov 17, 2021

minikube-pr-bot commented Nov 17, 2021

alias-dev commented Nov 17, 2021

minikube-pr-bot commented Nov 18, 2021

minikube-pr-bot commented Nov 18, 2021

minikube-pr-bot commented Nov 18, 2021

arthurk commented Dec 31, 2021

minikube-pr-bot commented Dec 31, 2021

minikube-pr-bot commented Dec 31, 2021

klaases commented Jan 25, 2022

k8s-triage-robot commented Apr 25, 2022

minikube-pr-bot commented May 12, 2022

minikube-pr-bot commented May 13, 2022

minikube-pr-bot commented May 16, 2022

minikube-pr-bot commented May 17, 2022

spowelljr left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jun 7, 2022

alias-dev commented Oct 20, 2021 •

edited

Loading