Remove useless check of baremetal driver for ingress addon

[zigarn]

Remove wrongly re-introduced (ee74d42, wrongly nested, so useless) check initially removed in #9577

[k8s-ci-robot]

Hi @zigarn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[sharifelgamal]

So this is a little more complex than it seems. The check itself is definitely in the wrong spot (a driver can't both be container-based and baremetal, clearly), but ingress is currently not working on baremetal at all, thus the reintroduction of the check,

[zigarn]

Works perfectly for us to use none driver and ingress addon.
It was explicitly enabled by #9577 and is available since 1.18.
The issue in #8841 (at the origin of this check in #8870) is simply a port-binding conflict as port 80 is already in use (that's a risk with driver none, but not a problem with the driver itself).

[sharifelgamal]

Good enough for me!

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12735) |
+----------------+----------+---------------------+
| minikube start | 47.8s    | 47.9s               |
| enable ingress | 31.5s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube start: 49.7s 47.1s 45.6s 47.8s 48.9s
Times for minikube (PR 12735) start: 47.9s 47.9s 49.3s 46.8s 47.5s

Times for minikube ingress: 31.3s 30.8s 31.3s 31.8s 32.3s
Times for minikube (PR 12735) ingress: 32.2s 33.8s 31.3s 31.3s 30.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12735) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.2s               |
| enable ingress | 33.4s    | 29.9s               |
+----------------+----------+---------------------+

Times for minikube start: 22.6s 21.4s 21.8s 22.2s 22.1s
Times for minikube (PR 12735) start: 21.2s 21.4s 21.3s 20.5s 21.6s

Times for minikube ingress: 34.4s 34.9s 34.9s 35.0s 27.5s
Times for minikube (PR 12735) ingress: 27.4s 27.9s 26.9s 28.4s 38.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12735) |
+----------------+----------+---------------------+
| minikube start | 41.4s    | 41.8s               |
| enable ingress | 33.1s    | 36.5s               |
+----------------+----------+---------------------+

Times for minikube start: 30.7s 43.9s 44.5s 43.8s 43.9s
Times for minikube (PR 12735) start: 37.0s 43.5s 40.7s 44.4s 43.3s

Times for minikube ingress: 43.4s 37.9s 32.9s 19.0s 32.4s
Times for minikube (PR 12735) ingress: 36.9s 23.4s 32.4s 55.9s 33.9s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux	TestAddons/serial/GCPAuth (gopogh)	0.62 (chart)
KVM_Linux_containerd	TestAddons/serial/GCPAuth (gopogh)	0.62 (chart)
KVM_Linux	TestAddons/serial/GCPAuth (gopogh)	0.62 (chart)
Docker_Linux_containerd	TestAddons/serial/GCPAuth (gopogh)	0.63 (chart)
Docker_Windows	TestDownloadOnlyKic (gopogh)	52.05 (chart)
Docker_Windows	TestDownloadOnly/v1.14.0/preload-exists (gopogh)	52.05 (chart)
Docker_Windows	TestDownloadOnly/v1.22.2/preload-exists (gopogh)	52.05 (chart)
Docker_Windows	TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh)	52.05 (chart)
Docker_Windows	TestNetworkPlugins/group/kindnet/DNS (gopogh)	70.65 (chart)
Docker_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	71.23 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	74.10 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	80.45 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	80.82 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/DNS (gopogh)	83.70 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Docker_Windows	TestCertOptions (gopogh)	100.00 (chart)
Docker_Windows	TestPause/serial/VerifyDeletedResources (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, zigarn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment