Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minikube-ingress-dns image to 0.0.2 #12730

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

sharifelgamal
Copy link
Collaborator

@sharifelgamal sharifelgamal commented Oct 19, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 19, 2021
@medyagh
Copy link
Member

medyagh commented Oct 19, 2021

Could we have a link to the code change on the image too please? (Either in comment or pr description)

@sharifelgamal
Copy link
Collaborator Author

Could we have a link to the code change on the image too please? (Either in comment or pr description)

Yep, done

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12730) |
+----------------+----------+---------------------+
| minikube start | 46.6s    | 46.8s               |
| enable ingress | 31.7s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 48.7s 45.9s 47.1s 45.4s 46.0s
Times for minikube (PR 12730) start: 47.3s 45.5s 47.4s 47.5s 46.5s

Times for minikube (PR 12730) ingress: 29.8s 31.2s 32.9s 31.8s 31.8s
Times for minikube ingress: 31.3s 31.7s 32.3s 30.9s 32.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12730) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 21.6s               |
| enable ingress | 32.8s    | 33.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 35.4s 34.9s 29.4s 28.4s 35.9s
Times for minikube (PR 12730) ingress: 27.4s 34.9s 35.4s 34.9s 36.9s

Times for minikube start: 22.8s 21.6s 21.5s 20.9s 21.9s
Times for minikube (PR 12730) start: 21.6s 21.4s 21.4s 21.8s 21.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12730) |
+----------------+----------+---------------------+
| minikube start | 40.0s    | 43.3s               |
| enable ingress | 30.6s    | 30.0s               |
+----------------+----------+---------------------+

Times for minikube start: 27.3s 41.6s 43.8s 42.9s 44.4s
Times for minikube (PR 12730) start: 43.8s 43.7s 42.8s 43.4s 42.6s

Times for minikube ingress: 37.9s 36.5s 19.5s 36.4s 22.5s
Times for minikube (PR 12730) ingress: 32.4s 19.9s 36.9s 33.9s 26.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestErrorSpam/setup (gopogh) 19.23 (chart)
Hyper-V_Windows TestDownloadOnly/v1.14.0/preload-exists (gopogh) 76.92 (chart)
Hyper-V_Windows TestDownloadOnly/v1.22.2/preload-exists (gopogh) 76.92 (chart)
Hyper-V_Windows TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh) 76.92 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 91c9af3 into kubernetes:master Oct 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants