Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only pass in APIServerName flag is specified #1245

Merged
merged 1 commit into from
Mar 16, 2017

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Mar 15, 2017

Otherwise, compatibility with old versions of localkube is broken in
all cases. APIServerName flag can still only be specified in v1.5.3 or
newer.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2017
@r2d4 r2d4 force-pushed the backwards-compatible branch 2 times, most recently from fa6e86f to 241d9fb Compare March 15, 2017 18:31
if kubernetesConfig.APIServerName != "" {
flagVals = append(flagVals, "--apiserver-name="+kubernetesConfig.APIServerName)
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dims
Copy link
Member

dims commented Mar 15, 2017

code change looks good 👍

@r2d4
Copy link
Contributor Author

r2d4 commented Mar 15, 2017

+ gsutil cp gs://minikube-builds/logs/index.html gs://minikube-builds/logs/1245/index.html
Traceback (most recent call last):
  File "/usr/bin/../lib/google-cloud-sdk/bin/bootstrapping/gsutil.py", line 12, in <module>
    import bootstrapping
  File "/usr/lib/google-cloud-sdk/bin/bootstrapping/bootstrapping.py", line 19, in <module>
    from googlecloudsdk.core import execution_utils
  File "/usr/lib/google-cloud-sdk/lib/googlecloudsdk/core/execution_utils.py", line 28, in <module>
    from googlecloudsdk.core import log
  File "/usr/lib/google-cloud-sdk/lib/googlecloudsdk/core/log.py", line 24, in <module>
    from googlecloudsdk.core import properties
  File "/usr/lib/google-cloud-sdk/lib/googlecloudsdk/core/properties.py", line 1288, in <module>
    VALUES = _Sections()
  File "/usr/lib/google-cloud-sdk/lib/googlecloudsdk/core/properties.py", line 238, in __init__
    self.proxy = _SectionProxy()
  File "/usr/lib/google-cloud-sdk/lib/googlecloudsdk/core/properties.py", line 964, in __init__
    valid_proxy_types = sorted(http_proxy_types.PROXY_TYPE_MAP.keys())
AttributeError: 'module' object has no attribute 'PROXY_TYPE_MAP'

gsutil is having an issue here, looking into it

@r2d4
Copy link
Contributor Author

r2d4 commented Mar 15, 2017

Above gsutil error is related to our jenkins that just got upgraded. Looking into it

@r2d4 r2d4 force-pushed the backwards-compatible branch 6 times, most recently from 91af5fd to 73500c8 Compare March 15, 2017 22:17
Otherwise, compatibility with old versions of localkube is broken in
all cases.  APIServerName flag can still only be specified in v1.5.3 or
newer.
@codecov-io
Copy link

Codecov Report

Merging #1245 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
- Coverage   43.22%   43.09%   -0.13%     
==========================================
  Files          48       48              
  Lines        2214     2216       +2     
==========================================
- Hits          957      955       -2     
- Misses       1102     1104       +2     
- Partials      155      157       +2
Impacted Files Coverage Δ
pkg/minikube/cluster/commands.go 65.47% <0%> (-1.6%)
pkg/minikube/kubeconfig/config.go 55.38% <0%> (-3.08%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 161d61f...bc10d55. Read the comment docs.

@r2d4
Copy link
Contributor Author

r2d4 commented Mar 16, 2017

Fixes #1220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants