-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only pass in APIServerName flag is specified #1245
Conversation
fa6e86f
to
241d9fb
Compare
if kubernetesConfig.APIServerName != "" { | ||
flagVals = append(flagVals, "--apiserver-name="+kubernetesConfig.APIServerName) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
code change looks good 👍 |
gsutil is having an issue here, looking into it |
Above gsutil error is related to our jenkins that just got upgraded. Looking into it |
91af5fd
to
73500c8
Compare
Otherwise, compatibility with old versions of localkube is broken in all cases. APIServerName flag can still only be specified in v1.5.3 or newer.
73500c8
to
bc10d55
Compare
Codecov Report
@@ Coverage Diff @@
## master #1245 +/- ##
==========================================
- Coverage 43.22% 43.09% -0.13%
==========================================
Files 48 48
Lines 2214 2216 +2
==========================================
- Hits 957 955 -2
- Misses 1102 1104 +2
- Partials 155 157 +2
Continue to review full report at Codecov.
|
Fixes #1220 |
Otherwise, compatibility with old versions of localkube is broken in
all cases. APIServerName flag can still only be specified in v1.5.3 or
newer.