Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang version to 1.17 #12378

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

minikube-bot
Copy link
Collaborator

Kubernetes Project just updated the golang version, updating minikube golang to match Kubernetes.

This PR was auto-generated by make update-golang-version using update-golang-versions.yml CI Workflow.

@minikube-bot minikube-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 30, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minikube-bot
To complete the pull request process, please assign sharifelgamal after the PR has been reviewed.
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator Author

Can one of the admins verify this patch?

@spowelljr
Copy link
Member

go mod tidy needs to be run because they made changes to the go.mod with 1.17

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12378) |
+----------------+----------+---------------------+
| minikube start | 54.4s    | 53.4s               |
| enable ingress | 32.7s    | 33.4s               |
+----------------+----------+---------------------+

Times for minikube start: 57.0s 50.5s 54.0s 54.4s 56.1s
Times for minikube (PR 12378) start: 53.2s 53.6s 54.8s 54.4s 50.9s

Times for minikube ingress: 32.9s 32.4s 32.3s 32.9s 32.9s
Times for minikube (PR 12378) ingress: 33.3s 33.9s 32.9s 34.0s 32.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12378) |
+----------------+----------+---------------------+
| minikube start | 23.1s    | 23.3s               |
| enable ingress | 27.6s    | 30.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 12378) start: 23.1s 23.9s 23.5s 23.8s 22.2s
Times for minikube start: 23.8s 21.9s 24.3s 23.0s 22.6s

Times for minikube ingress: 27.5s 28.0s 28.5s 27.0s 27.0s
Times for minikube (PR 12378) ingress: 27.5s 33.5s 30.5s 34.5s 27.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12378) |
+----------------+----------+---------------------+
| minikube start | 40.9s    | 40.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 28.0s 44.2s 45.1s 43.5s 44.0s
Times for minikube (PR 12378) start: 26.1s 45.6s 43.7s 44.2s 44.4s

@medyagh medyagh merged commit 4f005bd into kubernetes:master Aug 31, 2021
@medyagh medyagh changed the title bump golang version bump golang version to 1.17 Aug 31, 2021
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/SecondStart (gopogh) 0.00 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestPause/serial/Pause (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestPause/serial/VerifyStatus (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/MountCmd/specific-port (gopogh) 0.67 (chart)
KVM_Linux TestPause/serial/Pause (gopogh) 0.67 (chart)
KVM_Linux TestPause/serial/VerifyStatus (gopogh) 0.67 (chart)
KVM_Linux_containerd TestAddons/parallel/Ingress (gopogh) 1.33 (chart)
KVM_Linux TestAddons/parallel/Ingress (gopogh) 2.01 (chart)
Docker_Linux_crio TestAddons/parallel/HelmTiller (gopogh) 2.67 (chart)
Docker_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 2.68 (chart)
Docker_Linux TestAddons/parallel/HelmTiller (gopogh) 2.68 (chart)
KVM_Linux TestAddons/parallel/HelmTiller (gopogh) 2.68 (chart)
KVM_Linux_crio TestAddons/parallel/HelmTiller (gopogh) 2.74 (chart)
KVM_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 3.33 (chart)
Hyperkit_macOS TestAddons/parallel/HelmTiller (gopogh) 3.42 (chart)
Docker_macOS TestAddons/parallel/HelmTiller (gopogh) 3.92 (chart)
KVM_Linux TestFunctional/parallel/SaveImage (gopogh) 7.14 (chart)
Docker_Linux_containerd TestFunctional/parallel/SaveImage (gopogh) 8.93 (chart)
Docker_Windows TestNetworkPlugins/group/calico/DNS (gopogh) 12.50 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 13.68 (chart)
Docker_Linux_crio TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 21.33 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 24.00 (chart)
KVM_Linux_crio TestJSONOutput/stop/parallel/DistinctCurrentSteps (gopogh) 25.00 (chart)
KVM_Linux_crio TestJSONOutput/stop/parallel/IncreasingCurrentSteps (gopogh) 25.00 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 29.25 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 29.25 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/Pause (gopogh) 30.87 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants