fixes get ETCD version from kubernetes constants #11290 #12084

Srikrishnabh · 2021-08-01T08:21:19Z

…master_srikrishnabh

k8s-ci-robot · 2021-08-01T08:21:26Z

Welcome @Srikrishnabh!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-08-01T08:21:27Z

Hi @Srikrishnabh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2021-08-01T08:23:03Z

Can one of the admins verify this patch?

pkg/minikube/constants/constants_kubeadm_images.go

…master_srikrishnabh

medyagh

This pr looks good.

medyagh · 2021-09-28T00:46:01Z

@Srikrishnabh would you plz rebase

…master_srikrishnabh

Srikrishnabh · 2021-09-29T15:24:44Z

@Srikrishnabh would you plz rebase

@medyagh rebased.

spowelljr · 2021-10-05T18:57:39Z

hack/update/kubeadm_constants/update_kubeadm_constants.go

+}
+
+// getK8sVersion returns Kubernetes versions.
+func getK8sVersions(ctx context.Context, owner, repo string) (stable, latest, latestMM, latestP0 string, err error) {


latestMM & latestP0 aren't used anywhere, couldn't we just replace this whole function with a direct call to update.GHReleases?

removed latestMM & latestP0.

…master_srikrishnabh

medyagh

I suggest making this PR only import the constants and do not do any other changes such as chanigng mirror to gcr this might break other parts of minikube

medyagh · 2021-10-21T18:49:33Z

pkg/minikube/bootstrapper/images/kubeadm_test.go

-			"mirror.k8s.io/k8s-minikube/storage-provisioner:" + version.GetStorageProvisionerVersion(),
-			"mirror.k8s.io/kubernetesui/dashboard:v2.3.1",
-			"mirror.k8s.io/kubernetesui/metrics-scraper:v1.0.7",
+		{"v1.16.1", "k8s.gcr.io", false, []string{


why these are changed from "mirror.k8s.io" to "k8s.gcr.io"

this doen''t sound like doing what the PR title suggests it is doing

This was due to constants having the k8s.gcr.io as fixed repo. I have fixed this. Thanks.

medyagh · 2021-10-21T18:50:54Z

pkg/minikube/bootstrapper/images/images.go

 	}
-	return path.Join(kubernetesRepo(mirror), in+":"+cv)
+
+	return fmt.Sprintf("%s:%s", imageName, cv)


this seems like missing "kubernetesRepo(mirror)" don't we need that for --image-repositories and mirrors and china users?

…master_srikrishnabh

medyagh

I just tried to run this on my Mac M1 Laptop Arm64 but I got this error

I believe this needs to download arm64 binary instead

1:03:55 medya/workspace/minikube
master_srikrishnabh ⌅1
$ make update-kubeadm-constants 
(cd hack/update/kubeadm_constants && \
	 go run update_kubeadm_constants.go)
E1123 11:04:11.685666   47743 update_kubeadm_constants.go:122] failed to execute kubeadm command ./kubeadm-linux-amd64-v1.22.4
F1123 11:04:11.689208   47743 update_kubeadm_constants.go:84] fork/exec ./kubeadm-linux-amd64-v1.22.4: exec format error
goroutine 1 [running]:
k8s.io/klog/v2.stacks(0x1)
	/Users/medya/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:1038 +0xac
k8s.io/klog/v2.(*loggingT).output(0x101978340, 0x3, 0x0, 0x1400027a000, 0x0, {0x101686f83, 0x1b}, 0x54, 0x0)
	/Users/medya/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:987 +0x628
k8s.io/klog/v2.(*loggingT).println(0x101978340, 0x3, 0x0, {0x0, 0x0}, {0x1400035dfb0, 0x1, 0x1})
	/Users/medya/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:713 +0x14c
k8s.io/klog/v2.Fatalln(...)
	/Users/medya/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:1525
main.main()
	/Users/medya/workspace/minikube/hack/update/kubeadm_constants/update_kubeadm_constants.go:84 +0x544

goroutine 19 [chan receive]:
k8s.io/klog/v2.(*loggingT).flushDaemon(0x101978340)
	/Users/medya/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:1181 +0x70
created by k8s.io/klog/v2.init.0
	/Users/medya/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:420 +0x150

goroutine 8 [IO wait]:
internal/poll.runtime_pollWait(0x101d9e4f8, 0x72)
	/usr/local/go/src/runtime/netpoll.go:229 +0xa4
internal/poll.(*pollDesc).wait(0x1400021a698, 0x72, 0x0)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0x38
internal/poll.(*pollDesc).waitRead(...)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0x1400021a680, {0x140001be000, 0x2053, 0x2053})
	/usr/local/go/src/internal/poll/fd_unix.go:167 +0x1dc
net.(*netFD).Read(0x1400021a680, {0x140001be000, 0x2053, 0x2053})
	/usr/local/go/src/net/fd_posix.go:56 +0x44
net.(*conn).Read(0x14000010010, {0x140001be000, 0x2053, 0x2053})
	/usr/local/go/src/net/net.go:183 +0x4c
crypto/tls.(*atLeastReader).Read(0x140001860c0, {0x140001be000, 0x2053, 0x2053})
	/usr/local/go/src/crypto/tls/conn.go:777 +0x58
bytes.(*Buffer).ReadFrom(0x14000300278, {0x1015b2340, 0x140001860c0})
	/usr/local/go/src/bytes/buffer.go:204 +0xa4
crypto/tls.(*Conn).readFromUntil(0x14000300000, {0x128b30008, 0x14000010010}, 0x5)
	/usr/local/go/src/crypto/tls/conn.go:799 +0xe0
crypto/tls.(*Conn).readRecordOrCCS(0x14000300000, 0x0)
	/usr/local/go/src/crypto/tls/conn.go:606 +0xf4
crypto/tls.(*Conn).readRecord(...)
	/usr/local/go/src/crypto/tls/conn.go:574
crypto/tls.(*Conn).Read(0x14000300000, {0x14000478000, 0x1000, 0x1000})
	/usr/local/go/src/crypto/tls/conn.go:1277 +0x164
bufio.(*Reader).Read(0x14000470060, {0x14000423538, 0x9, 0x9})
	/usr/local/go/src/bufio/bufio.go:227 +0x20c
io.ReadAtLeast({0x1015b21e0, 0x14000470060}, {0x14000423538, 0x9, 0x9}, 0x9)
	/usr/local/go/src/io/io.go:328 +0xa0
io.ReadFull(...)
	/usr/local/go/src/io/io.go:347
net/http.http2readFrameHeader({0x14000423538, 0x9, 0x9}, {0x1015b21e0, 0x14000470060})
	/usr/local/go/src/net/http/h2_bundle.go:1553 +0x5c
net/http.(*http2Framer).ReadFrame(0x14000423500)
	/usr/local/go/src/net/http/h2_bundle.go:1811 +0x90
net/http.(*http2clientConnReadLoop).run(0x1400005ffa8)
	/usr/local/go/src/net/http/h2_bundle.go:8437 +0x13c
net/http.(*http2ClientConn).readLoop(0x1400007e180)
	/usr/local/go/src/net/http/h2_bundle.go:8359 +0x60
created by net/http.(*http2Transport).newClientConn
	/usr/local/go/src/net/http/h2_bundle.go:7311 +0xb48

goroutine 26 [IO wait]:
internal/poll.runtime_pollWait(0x101d9e410, 0x72)
	/usr/local/go/src/runtime/netpoll.go:229 +0xa4
internal/poll.(*pollDesc).wait(0x140004a5398, 0x72, 0x0)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0x38
internal/poll.(*pollDesc).waitRead(...)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0x140004a5380, {0x14000594000, 0xe5a2, 0xe5a2})
	/usr/local/go/src/internal/poll/fd_unix.go:167 +0x1dc
net.(*netFD).Read(0x140004a5380, {0x14000594000, 0xe5a2, 0xe5a2})
	/usr/local/go/src/net/fd_posix.go:56 +0x44
net.(*conn).Read(0x14000132720, {0x14000594000, 0xe5a2, 0xe5a2})
	/usr/local/go/src/net/net.go:183 +0x4c
crypto/tls.(*atLeastReader).Read(0x1400037af30, {0x14000594000, 0xe5a2, 0xe5a2})
	/usr/local/go/src/crypto/tls/conn.go:777 +0x58
bytes.(*Buffer).ReadFrom(0x1400028c5f8, {0x1015b2340, 0x1400037af30})
	/usr/local/go/src/bytes/buffer.go:204 +0xa4
crypto/tls.(*Conn).readFromUntil(0x1400028c380, {0x128b30008, 0x14000132720}, 0x5)
	/usr/local/go/src/crypto/tls/conn.go:799 +0xe0
crypto/tls.(*Conn).readRecordOrCCS(0x1400028c380, 0x0)
	/usr/local/go/src/crypto/tls/conn.go:606 +0xf4
crypto/tls.(*Conn).readRecord(...)
	/usr/local/go/src/crypto/tls/conn.go:574
crypto/tls.(*Conn).Read(0x1400028c380, {0x140002c0000, 0x1000, 0x1000})
	/usr/local/go/src/crypto/tls/conn.go:1277 +0x164
bufio.(*Reader).Read(0x140002bca20, {0x14000206498, 0x9, 0x9})
	/usr/local/go/src/bufio/bufio.go:227 +0x20c
io.ReadAtLeast({0x1015b21e0, 0x140002bca20}, {0x14000206498, 0x9, 0x9}, 0x9)
	/usr/local/go/src/io/io.go:328 +0xa0
io.ReadFull(...)
	/usr/local/go/src/io/io.go:347
net/http.http2readFrameHeader({0x14000206498, 0x9, 0x9}, {0x1015b21e0, 0x140002bca20})
	/usr/local/go/src/net/http/h2_bundle.go:1553 +0x5c
net/http.(*http2Framer).ReadFrame(0x14000206460)
	/usr/local/go/src/net/http/h2_bundle.go:1811 +0x90
net/http.(*http2clientConnReadLoop).run(0x140004b5fa8)
	/usr/local/go/src/net/http/h2_bundle.go:8437 +0x13c
net/http.(*http2ClientConn).readLoop(0x14000260a80)
	/usr/local/go/src/net/http/h2_bundle.go:8359 +0x60
created by net/http.(*http2Transport).newClientConn
	/usr/local/go/src/net/http/h2_bundle.go:7311 +0xb48
exit status 255
make: *** [update-kubeadm-constants] Error 1
11:04:11 medya/workspace/minikube
master_srikrishnabh ⌅2
$

Srikrishnabh · 2021-11-30T07:33:51Z

I just tried to run this on my Mac M1 Laptop Arm64 but I got this error

I believe this needs to download arm64 binary instead

1:03:55 medya/workspace/minikube
master_srikrishnabh ⌅1
$ make update-kubeadm-constants 
(cd hack/update/kubeadm_constants && \
	 go run update_kubeadm_constants.go)
E1123 11:04:11.685666   47743 update_kubeadm_constants.go:122] failed to execute kubeadm command ./kubeadm-linux-amd64-v1.22.4
F1123 11:04:11.689208   47743 update_kubeadm_constants.go:84] fork/exec ./kubeadm-linux-amd64-v1.22.4: exec format error
goroutine 1 [running]:
k8s.io/klog/v2.stacks(0x1)
	/Users/medya/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:1038 +0xac
k8s.io/klog/v2.(*loggingT).output(0x101978340, 0x3, 0x0, 0x1400027a000, 0x0, {0x101686f83, 0x1b}, 0x54, 0x0)
	/Users/medya/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:987 +0x628
k8s.io/klog/v2.(*loggingT).println(0x101978340, 0x3, 0x0, {0x0, 0x0}, {0x1400035dfb0, 0x1, 0x1})
	/Users/medya/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:713 +0x14c
k8s.io/klog/v2.Fatalln(...)
	/Users/medya/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:1525
main.main()
	/Users/medya/workspace/minikube/hack/update/kubeadm_constants/update_kubeadm_constants.go:84 +0x544

goroutine 19 [chan receive]:
k8s.io/klog/v2.(*loggingT).flushDaemon(0x101978340)
	/Users/medya/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:1181 +0x70
created by k8s.io/klog/v2.init.0
	/Users/medya/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:420 +0x150

goroutine 8 [IO wait]:
internal/poll.runtime_pollWait(0x101d9e4f8, 0x72)
	/usr/local/go/src/runtime/netpoll.go:229 +0xa4
internal/poll.(*pollDesc).wait(0x1400021a698, 0x72, 0x0)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0x38
internal/poll.(*pollDesc).waitRead(...)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0x1400021a680, {0x140001be000, 0x2053, 0x2053})
	/usr/local/go/src/internal/poll/fd_unix.go:167 +0x1dc
net.(*netFD).Read(0x1400021a680, {0x140001be000, 0x2053, 0x2053})
	/usr/local/go/src/net/fd_posix.go:56 +0x44
net.(*conn).Read(0x14000010010, {0x140001be000, 0x2053, 0x2053})
	/usr/local/go/src/net/net.go:183 +0x4c
crypto/tls.(*atLeastReader).Read(0x140001860c0, {0x140001be000, 0x2053, 0x2053})
	/usr/local/go/src/crypto/tls/conn.go:777 +0x58
bytes.(*Buffer).ReadFrom(0x14000300278, {0x1015b2340, 0x140001860c0})
	/usr/local/go/src/bytes/buffer.go:204 +0xa4
crypto/tls.(*Conn).readFromUntil(0x14000300000, {0x128b30008, 0x14000010010}, 0x5)
	/usr/local/go/src/crypto/tls/conn.go:799 +0xe0
crypto/tls.(*Conn).readRecordOrCCS(0x14000300000, 0x0)
	/usr/local/go/src/crypto/tls/conn.go:606 +0xf4
crypto/tls.(*Conn).readRecord(...)
	/usr/local/go/src/crypto/tls/conn.go:574
crypto/tls.(*Conn).Read(0x14000300000, {0x14000478000, 0x1000, 0x1000})
	/usr/local/go/src/crypto/tls/conn.go:1277 +0x164
bufio.(*Reader).Read(0x14000470060, {0x14000423538, 0x9, 0x9})
	/usr/local/go/src/bufio/bufio.go:227 +0x20c
io.ReadAtLeast({0x1015b21e0, 0x14000470060}, {0x14000423538, 0x9, 0x9}, 0x9)
	/usr/local/go/src/io/io.go:328 +0xa0
io.ReadFull(...)
	/usr/local/go/src/io/io.go:347
net/http.http2readFrameHeader({0x14000423538, 0x9, 0x9}, {0x1015b21e0, 0x14000470060})
	/usr/local/go/src/net/http/h2_bundle.go:1553 +0x5c
net/http.(*http2Framer).ReadFrame(0x14000423500)
	/usr/local/go/src/net/http/h2_bundle.go:1811 +0x90
net/http.(*http2clientConnReadLoop).run(0x1400005ffa8)
	/usr/local/go/src/net/http/h2_bundle.go:8437 +0x13c
net/http.(*http2ClientConn).readLoop(0x1400007e180)
	/usr/local/go/src/net/http/h2_bundle.go:8359 +0x60
created by net/http.(*http2Transport).newClientConn
	/usr/local/go/src/net/http/h2_bundle.go:7311 +0xb48

goroutine 26 [IO wait]:
internal/poll.runtime_pollWait(0x101d9e410, 0x72)
	/usr/local/go/src/runtime/netpoll.go:229 +0xa4
internal/poll.(*pollDesc).wait(0x140004a5398, 0x72, 0x0)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0x38
internal/poll.(*pollDesc).waitRead(...)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0x140004a5380, {0x14000594000, 0xe5a2, 0xe5a2})
	/usr/local/go/src/internal/poll/fd_unix.go:167 +0x1dc
net.(*netFD).Read(0x140004a5380, {0x14000594000, 0xe5a2, 0xe5a2})
	/usr/local/go/src/net/fd_posix.go:56 +0x44
net.(*conn).Read(0x14000132720, {0x14000594000, 0xe5a2, 0xe5a2})
	/usr/local/go/src/net/net.go:183 +0x4c
crypto/tls.(*atLeastReader).Read(0x1400037af30, {0x14000594000, 0xe5a2, 0xe5a2})
	/usr/local/go/src/crypto/tls/conn.go:777 +0x58
bytes.(*Buffer).ReadFrom(0x1400028c5f8, {0x1015b2340, 0x1400037af30})
	/usr/local/go/src/bytes/buffer.go:204 +0xa4
crypto/tls.(*Conn).readFromUntil(0x1400028c380, {0x128b30008, 0x14000132720}, 0x5)
	/usr/local/go/src/crypto/tls/conn.go:799 +0xe0
crypto/tls.(*Conn).readRecordOrCCS(0x1400028c380, 0x0)
	/usr/local/go/src/crypto/tls/conn.go:606 +0xf4
crypto/tls.(*Conn).readRecord(...)
	/usr/local/go/src/crypto/tls/conn.go:574
crypto/tls.(*Conn).Read(0x1400028c380, {0x140002c0000, 0x1000, 0x1000})
	/usr/local/go/src/crypto/tls/conn.go:1277 +0x164
bufio.(*Reader).Read(0x140002bca20, {0x14000206498, 0x9, 0x9})
	/usr/local/go/src/bufio/bufio.go:227 +0x20c
io.ReadAtLeast({0x1015b21e0, 0x140002bca20}, {0x14000206498, 0x9, 0x9}, 0x9)
	/usr/local/go/src/io/io.go:328 +0xa0
io.ReadFull(...)
	/usr/local/go/src/io/io.go:347
net/http.http2readFrameHeader({0x14000206498, 0x9, 0x9}, {0x1015b21e0, 0x140002bca20})
	/usr/local/go/src/net/http/h2_bundle.go:1553 +0x5c
net/http.(*http2Framer).ReadFrame(0x14000206460)
	/usr/local/go/src/net/http/h2_bundle.go:1811 +0x90
net/http.(*http2clientConnReadLoop).run(0x140004b5fa8)
	/usr/local/go/src/net/http/h2_bundle.go:8437 +0x13c
net/http.(*http2ClientConn).readLoop(0x14000260a80)
	/usr/local/go/src/net/http/h2_bundle.go:8359 +0x60
created by net/http.(*http2Transport).newClientConn
	/usr/local/go/src/net/http/h2_bundle.go:7311 +0xb48
exit status 255
make: *** [update-kubeadm-constants] Error 1
11:04:11 medya/workspace/minikube
master_srikrishnabh ⌅2
$

@medyagh I'm not able to get the kubeadm for mac 1 (darwin-arm64) version. is there a link where I can download it.?

medyagh · 2021-12-02T22:37:03Z

you are right @Srikrishnabh sorry I will try to test this PR on Linux

medyagh

this looks good to me thank you @Srikrishnabh

medyagh · 2021-12-02T22:58:34Z

/ok-to-test

k8s-ci-robot · 2021-12-02T22:58:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, Srikrishnabh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2021-12-03T03:06:31Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12084) |
+----------------+----------+---------------------+
| minikube start | 47.1s    | 46.4s               |
| enable ingress | 30.5s    | 30.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 30.7s 30.3s 29.7s 30.8s 30.8s
Times for minikube (PR 12084) ingress: 31.8s 30.7s 30.7s 30.8s 30.2s

Times for minikube start: 48.5s 45.7s 46.4s 47.7s 47.2s
Times for minikube (PR 12084) start: 46.0s 46.0s 47.0s 46.4s 46.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12084) |
+----------------+----------+---------------------+
| minikube start | 21.4s    | 21.0s               |
| enable ingress | 37.9s    | 26.2s               |
+----------------+----------+---------------------+

Times for minikube start: 22.0s 20.9s 21.1s 21.0s 22.0s
Times for minikube (PR 12084) start: 21.6s 20.5s 21.4s 21.2s 20.2s

Times for minikube ingress: 27.4s 27.9s 25.4s 83.0s 25.9s
Times for minikube (PR 12084) ingress: 24.9s 26.9s 26.4s 26.4s 26.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12084) |
+----------------+----------+---------------------+
| minikube start | 38.1s    | 41.2s               |
| enable ingress | 26.2s    | 23.4s               |
+----------------+----------+---------------------+

Times for minikube start: 25.7s 40.7s 41.7s 41.2s 41.3s
Times for minikube (PR 12084) start: 41.6s 40.9s 41.5s 40.8s 41.3s

Times for minikube ingress: 33.4s 17.9s 31.4s 21.4s 26.9s
Times for minikube (PR 12084) ingress: 16.9s 27.4s 26.9s 17.9s 27.9s

minikube-pr-bot · 2021-12-03T03:17:03Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestMultiNode/serial/AddNode (gopogh)	1.46 (chart)
Docker_macOS	TestMultiNode/serial/StartAfterStop (gopogh)	1.46 (chart)
Docker_Linux_containerd	TestPause/serial/Pause (gopogh)	4.46 (chart)
Docker_Linux_containerd	TestPause/serial/VerifyStatus (gopogh)	4.46 (chart)
Docker_Linux_containerd	TestPause/serial/PauseAgain (gopogh)	6.37 (chart)
Hyper-V_Windows	TestErrorSpam/setup (gopogh)	15.50 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/ProfileList (gopogh)	25.23 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh)	29.41 (chart)
Hyper-V_Windows	TestMultiNode/serial/CopyFile (gopogh)	68.22 (chart)
Docker_macOS	TestDownloadOnly/v1.16.0/preload-exists (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartKeepsNodes (gopogh)	100.00 (chart)
Hyper-V_Windows	TestRunningBinaryUpgrade (gopogh)	100.00 (chart)
Hyper-V_Windows	TestStoppedBinaryUpgrade/Upgrade (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

Srikrishnabh · 2021-12-05T07:36:36Z

this looks good to me thank you @Srikrishnabh

Thank you @medyagh

Srikrishnabh added 4 commits July 27, 2021 23:41

initial fix on update kubeadm images automatically

5f46b98

added makefile target

8f04834

Merge branch 'master' of https://github.com/kubernetes/minikube into …

efbfbc1

…master_srikrishnabh

added gofmt for constants_kubeadm_images

837c73d

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2021

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 1, 2021

k8s-ci-robot requested review from prasadkatti and prezha August 1, 2021 08:21

fixed formatting

ddfcf46

afbjorklund mentioned this pull request Aug 23, 2021

Add kubeadm image versions for kubernetes 1.22 #12331

Merged

afbjorklund requested changes Aug 23, 2021

View reviewed changes

pkg/minikube/constants/constants_kubeadm_images.go Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2021

Srikrishnabh added 2 commits August 26, 2021 19:20

fixed kubeadm image version for 22

e744f3e

Merge branch 'master' of https://github.com/kubernetes/minikube into …

6a9d08e

…master_srikrishnabh

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2021

Srikrishnabh requested a review from afbjorklund September 10, 2021 18:07

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2021

medyagh reviewed Sep 28, 2021

View reviewed changes

Srikrishnabh added 2 commits September 29, 2021 20:28

Merge branch 'master' of https://github.com/kubernetes/minikube into …

ab496e6

…master_srikrishnabh

updated the test data kubeadm_test.go

7e7a97e

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2021

Srikrishnabh requested a review from medyagh September 29, 2021 15:27

spowelljr reviewed Oct 5, 2021

View reviewed changes

Merge branch 'master' of https://github.com/kubernetes/minikube into …

2d7e884

…master_srikrishnabh

Srikrishnabh requested a review from spowelljr October 18, 2021 17:48

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2021

Srikrishnabh added 2 commits October 21, 2021 22:51

removed vars latestP0 latestMM from update kubeadm consts

991d9d4

Merge branch 'master' of https://github.com/kubernetes/minikube into …

fce35c9

…master_srikrishnabh

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2021

updated kubeadm-constants image version

d0928b1

medyagh requested changes Oct 21, 2021

View reviewed changes

Srikrishnabh added 2 commits November 7, 2021 00:25

fixed review comments

7dd0eb0

Merge branch 'master' of https://github.com/kubernetes/minikube into …

c80793c

…master_srikrishnabh

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 6, 2021

Srikrishnabh requested a review from medyagh November 6, 2021 19:03

medyagh requested changes Nov 23, 2021

View reviewed changes

medyagh approved these changes Dec 2, 2021

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2021

medyagh merged commit aa9c380 into kubernetes:master Dec 7, 2021

medyagh mentioned this pull request Dec 7, 2021

CI: add job to auto-update kubeadm constants for images #13108

Merged

afbjorklund mentioned this pull request Dec 10, 2021

k8s v1.24.0-alpha.1: The image 'k8s.gcr.io/coredns/coredns:1.8.4' was not found; unable to add it to cache. #13136

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes get ETCD version from kubernetes constants #11290 #12084

fixes get ETCD version from kubernetes constants #11290 #12084

Srikrishnabh commented Aug 1, 2021

k8s-ci-robot commented Aug 1, 2021

k8s-ci-robot commented Aug 1, 2021

minikube-bot commented Aug 1, 2021

medyagh left a comment

medyagh commented Sep 28, 2021

Srikrishnabh commented Sep 29, 2021

spowelljr Oct 5, 2021

Srikrishnabh Oct 18, 2021

medyagh left a comment

medyagh Oct 21, 2021

Srikrishnabh Nov 6, 2021

medyagh Oct 21, 2021

Srikrishnabh Nov 6, 2021

medyagh left a comment

Srikrishnabh commented Nov 30, 2021

medyagh commented Dec 2, 2021

medyagh left a comment

medyagh commented Dec 2, 2021

k8s-ci-robot commented Dec 2, 2021

minikube-pr-bot commented Dec 3, 2021

minikube-pr-bot commented Dec 3, 2021

Srikrishnabh commented Dec 5, 2021

fixes get ETCD version from kubernetes constants #11290 #12084

fixes get ETCD version from kubernetes constants #11290 #12084

Conversation

Srikrishnabh commented Aug 1, 2021

k8s-ci-robot commented Aug 1, 2021

k8s-ci-robot commented Aug 1, 2021

minikube-bot commented Aug 1, 2021

medyagh left a comment

Choose a reason for hiding this comment

medyagh commented Sep 28, 2021

Srikrishnabh commented Sep 29, 2021

spowelljr Oct 5, 2021

Choose a reason for hiding this comment

Srikrishnabh Oct 18, 2021

Choose a reason for hiding this comment

medyagh left a comment

Choose a reason for hiding this comment

medyagh Oct 21, 2021

Choose a reason for hiding this comment

Srikrishnabh Nov 6, 2021

Choose a reason for hiding this comment

medyagh Oct 21, 2021

Choose a reason for hiding this comment

Srikrishnabh Nov 6, 2021

Choose a reason for hiding this comment

medyagh left a comment

Choose a reason for hiding this comment

Srikrishnabh commented Nov 30, 2021

medyagh commented Dec 2, 2021

medyagh left a comment

Choose a reason for hiding this comment

medyagh commented Dec 2, 2021

k8s-ci-robot commented Dec 2, 2021

minikube-pr-bot commented Dec 3, 2021

minikube-pr-bot commented Dec 3, 2021

Srikrishnabh commented Dec 5, 2021