Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test break #1196

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Fix test break #1196

merged 1 commit into from
Feb 28, 2017

Conversation

dims
Copy link
Member

@dims dims commented Feb 28, 2017

pull request #1149 from aaron-prindle/api-name-configurable caused a break in the test added as part of pull request #1157

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@r2d4
Copy link
Contributor

r2d4 commented Feb 28, 2017

@minikube-bot OK to test

@r2d4
Copy link
Contributor

r2d4 commented Feb 28, 2017

Yeah sorry about that, my PR which added this test was merged after @aaron-prindle's tests had ran.

Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r2d4 r2d4 merged commit 0c616a6 into kubernetes:master Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants