Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-pause: cleanup on ticker allocations. #11909

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

vishjain
Copy link
Contributor

@vishjain vishjain commented Jul 6, 2021

fixes #10596

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 6, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @vishjain. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@vishjain
Copy link
Contributor Author

vishjain commented Jul 6, 2021

Here is the outout:
minikube vishal$ minikube addons enable auto-pause

❗ Executing "docker container inspect minikube --format={{.State.Status}}" took an unusually long time: 2.611768229s
💡 Restarting the docker service may improve performance.
▪ Using image gcr.io/k8s-minikube/auto-pause-hook:v0.0.2
▪ auto-pause addon is an alpha feature and still in early development. Please file issues to help us make it better.
https://github.com/kubernetes/minikube/labels/co/auto-pause

@vishjain vishjain force-pushed the user/vishal/memory-leak/master branch from d4c0dad to d431cf6 Compare July 6, 2021 06:35
@vishjain vishjain force-pushed the user/vishal/memory-leak/master branch from d431cf6 to e0c3403 Compare July 25, 2021 22:09
@vishjain vishjain force-pushed the user/vishal/memory-leak/master branch from e0c3403 to 7cda4bb Compare July 25, 2021 22:28
@vishjain vishjain requested a review from andriyDev July 25, 2021 23:15
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2021
@vishjain
Copy link
Contributor Author

@andriyDev can you please review this? Thanks!

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @vishjain

@medyagh medyagh merged commit 48424c5 into kubernetes:master Nov 17, 2021
@medyagh medyagh changed the title Cleanup on ticker allocations. auto-pause: cleanup on ticker allocations. Nov 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, vishjain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto-pause: make it memory-leak proof
6 participants