Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ISO changes #11799

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Conversation

ilya-zuyev
Copy link
Contributor

This PR reverts #11778 and #11688

…ease-v1.22.0-beta.0"

This reverts commit fd703f9, reversing
changes made to 0b170db.
…t-2021.02"

This reverts commit 02abe78, reversing
changes made to 4d078ae.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2021
@ilya-zuyev
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11799) |
+----------------+----------+---------------------+
| minikube start | 46.8s    | 47.5s               |
| enable ingress | 41.2s    | 35.5s               |
+----------------+----------+---------------------+

Times for minikube start: 48.4s 46.3s 47.2s 46.0s 45.9s
Times for minikube (PR 11799) start: 47.4s 46.7s 46.2s 46.6s 50.8s

Times for minikube ingress: 35.2s 43.7s 41.9s 42.8s 42.7s
Times for minikube (PR 11799) ingress: 34.2s 37.2s 33.8s 35.3s 37.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11799) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 22.5s               |
| enable ingress | 35.3s    | 35.1s               |
+----------------+----------+---------------------+

Times for minikube start: 22.6s 22.3s 21.9s 22.4s 22.5s
Times for minikube (PR 11799) start: 23.0s 23.3s 22.2s 22.0s 21.8s

Times for minikube ingress: 37.5s 37.5s 34.5s 33.0s 34.0s
Times for minikube (PR 11799) ingress: 33.5s 34.0s 37.5s 37.5s 33.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11799) |
+----------------+----------+---------------------+
| minikube start | 42.1s    | 43.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.2s 44.2s 44.9s 47.3s 42.9s
Times for minikube (PR 11799) start: 42.9s 43.7s 42.8s 42.2s 43.6s

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on Docker_Linux_containerd.

Failed Tests Flake Rate (%)
TestStoppedBinaryUpgrade 100.00 (chart)

To see the flake rates of all tests on Docker_Linux_containerd, click here.

@medyagh
Copy link
Member

medyagh commented Jun 29, 2021

@ilya-zuyev mind adding some details about the issue and why we are reverting this?

@ilya-zuyev ilya-zuyev merged commit f01e15f into kubernetes:master Jun 29, 2021
@ilya-zuyev
Copy link
Contributor Author

ilya-zuyev commented Jun 29, 2021

@ilya-zuyev mind adding some details about the issue and why we are reverting this?

We found an issue with Cilium CNI.
Network got broken for KVM driver for all container runtimes.

See for example https://storage.googleapis.com/minikube-builds/logs/11791/b8ae8cd/KVM_Linux.html#fail_TestNetworkPlugins%2fgroup%2fcilium%2fDNS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants