Add ability to pass 'max' value to memory and cpus flags

[spowelljr]

Part of #11650

Problem:
There's currently no way to automatically maximize memory and cpu allocation.

Solution:
Added the ability to pass mamx to the memory and cpus flags on minikube start. Passing that value will allocate maximum resources to minikube.

Example:

minikube start --memory=max cpus=max
...
🔥  Creating docker container (CPUs=6, Memory=5945MB) ...

[medyagh]

if this is a VM driver user sets --CPUs=Max what happens?

[medyagh]

as part of this PR I think I was expecting to see the oci package be touched in a way that this line should NOt be appended (and leave it without --memory

		if memcg {
			runArgs = append(runArgs, fmt.Sprintf("--memory=%s", p.Memory))
		}

https://github.com/medyagh/minikube/blob/00cc926649f84edf2dc5b4a202ceaafb7a79e727/pkg/drivers/kic/oci/oci.go#L212

[medyagh]

could we see metrics of time2k8s after this PR ? does it make any diff?

[spowelljr]

could we see metrics of time2k8s after this PR ? does it make any diff?

The minikube start command completes 2.7 seconds faster with --memory=max --cpus=max flags used.

[medyagh]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11692) |
+----------------+----------+---------------------+
| minikube start | 48.3s    | 48.4s               |
| enable ingress | 37.9s    | 38.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 38.8s 35.7s 35.3s 42.8s 36.8s
Times for minikube (PR 11692) ingress: 34.8s 41.8s 41.8s 38.3s 33.8s

Times for minikube (PR 11692) start: 51.3s 50.0s 47.3s 47.4s 46.0s
Times for minikube start: 49.7s 46.7s 48.1s 48.7s 48.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11692) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 22.1s               |
| enable ingress | 34.9s    | 35.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 11692) start: 22.6s 21.9s 21.8s 22.7s 21.5s
Times for minikube start: 23.6s 21.4s 22.1s 22.6s 21.8s

Times for minikube ingress: 33.0s 35.5s 33.5s 38.0s 34.5s
Times for minikube (PR 11692) ingress: 34.5s 37.5s 35.0s 32.5s 38.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11692) |
+----------------+----------+---------------------+
| minikube start | 42.1s    | 44.4s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 11692) start: 43.3s 43.7s 43.6s 47.5s 43.8s
Times for minikube start: 32.4s 43.6s 43.5s 47.4s 43.8s