Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist custom addon image/registry settings. #11432

Merged
merged 7 commits into from
May 20, 2021
Merged

Persist custom addon image/registry settings. #11432

merged 7 commits into from
May 20, 2021

Commits on May 18, 2021

  1. Refactor assets/addons.go to de-dupe map parsing.

    @andriyDev
    andriyDev committed May 18, 2021
    Configuration menu
    Copy the full SHA
    62b2c94 View commit details
    Browse the repository at this point in the history

  2. Move (custom) image selection to its own function.

    @andriyDev
    andriyDev committed May 18, 2021
    Configuration menu
    Copy the full SHA
    7684a14 View commit details
    Browse the repository at this point in the history

  3. Persist custom addon image settings.

    @andriyDev
    andriyDev committed May 18, 2021
    Configuration menu
    Copy the full SHA
    040e7e7 View commit details
    Browse the repository at this point in the history

  4. Create tests to ensure custom addon images persist.

    @andriyDev
    andriyDev committed May 18, 2021
    Configuration menu
    Copy the full SHA
    7998c8d View commit details
    Browse the repository at this point in the history

  5. Run make generate-docs.

    @andriyDev
    andriyDev committed May 18, 2021
    Configuration menu
    Copy the full SHA
    4688412 View commit details
    Browse the repository at this point in the history

  6. Create unit tests for new utility functions in pkg/minikube/assets/ad… 

    …dons.go.
    @andriyDev
    andriyDev committed May 18, 2021
    Configuration menu
    Copy the full SHA
    6c31137 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Add comments to types.go for CustomAddonImages/CustomAddonRegistries.

    @andriyDev
    andriyDev committed May 19, 2021
    Configuration menu
    Copy the full SHA
    df32362 View commit details
    Browse the repository at this point in the history