Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New command: build to build images using minikube #11164

Merged
merged 28 commits into from
Apr 25, 2021
Merged

New command: build to build images using minikube #11164

merged 28 commits into from
Apr 25, 2021

Commits on Apr 21, 2021

  1. Add initial re-implementation of the build command 

    Currently only handles tarballs, not directories
    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    af5828d View commit details
    Browse the repository at this point in the history

  2. Add some basic support for setting the image tag

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    a274482 View commit details
    Browse the repository at this point in the history

  3. Add support for build directory and Dockerfile 

    Will create a temporary tarball, if given a dir

Some code from github.com/fsouza/go-dockerclient
(but not exported as a library, for some reason)

Upgrade docker client and cherry-pick windows

From v18.09.0 to v19.03.15, plus c3a0a37446
Update go-dockerclient and remove internal deps
    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    9ef5d25 View commit details
    Browse the repository at this point in the history

  4. Generate documentation for the build command

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    6f26e4b View commit details
    Browse the repository at this point in the history

  5. Move minikube build cmd to minikube image build 

    Use the long name also for examples and usage
    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    6cfbf2c View commit details
    Browse the repository at this point in the history

  6. Make sure to show output from build cmd

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    844c696 View commit details
    Browse the repository at this point in the history

  7. Make sure to pass any file param to build

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    c94a6d7 View commit details
    Browse the repository at this point in the history

  8. Move absolute file path handling to machine

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    f670368 View commit details
    Browse the repository at this point in the history

  9. Don't add build context to the default file

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    22150fb View commit details
    Browse the repository at this point in the history

  10. Don't fail when the default file is passed

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    a8a8788 View commit details
    Browse the repository at this point in the history

  11. Add option for pushing image to registry

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    02b4267 View commit details
    Browse the repository at this point in the history

  12. Improve comments and remove docker daemon

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    40cbe65 View commit details
    Browse the repository at this point in the history

  13. Allow building image from an url as well

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    9f9958f View commit details
    Browse the repository at this point in the history

  14. Allow building tarball from stdin stream

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    db203cd View commit details
    Browse the repository at this point in the history

  15. Allow passing environ and options to build

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    c961190 View commit details
    Browse the repository at this point in the history

  16. Add git url support to containerd runtime

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    947e31a View commit details
    Browse the repository at this point in the history

  17. Address lint append suggestions from gocritic

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    e230f02 View commit details
    Browse the repository at this point in the history

  18. Add example parameters to the usage help text

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    9516122 View commit details
    Browse the repository at this point in the history

  19. Regenerate documentation for the unit test

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    c715324 View commit details
    Browse the repository at this point in the history

  20. Clean up duplicated function etc after merge

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    f7e0777 View commit details
    Browse the repository at this point in the history

  21. Clean up the order of the image commands

    @afbjorklund
    afbjorklund committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    943561b View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Add skeleton for minikube image integration test

    @afbjorklund
    afbjorklund committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    a5f835b View commit details
    Browse the repository at this point in the history

  2. Make sure to start buildkit socket for containerd

    @afbjorklund
    afbjorklund committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    93c40d1 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Move the BuildImage test over to functional test

    @afbjorklund
    afbjorklund committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    c9a0a7a View commit details
    Browse the repository at this point in the history

  2. Use canonical names for the functional test images 

    And add some cleanup and improved logging as well
    @afbjorklund
    afbjorklund committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    5d8d3d3 View commit details
    Browse the repository at this point in the history

  3. url.Parse treats DOS volumes as URL schemes 

    So need to be on the lookout for "C:\\path"
    @afbjorklund
    afbjorklund committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    d508459 View commit details
    Browse the repository at this point in the history

  4. Support building a path local to the machine 

    Using file: scheme means build local context
    @afbjorklund
    afbjorklund committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    96e199c View commit details
    Browse the repository at this point in the history

  5. The docker container runtime doesn't show name 

    It hides the docker.io and the "library" parts
    @afbjorklund
    afbjorklund committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    4d0c0c6 View commit details
    Browse the repository at this point in the history