UI: Add log file to GitHub issue output #11158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
Can one of the admins verify this patch? |
spowelljr
changed the title
medyagh
reviewed
Apr 20, 2021
medyagh
requested changes
Apr 20, 2021
medyagh
requested changes
Apr 20, 2021
k8s-ci-robot
added
size/L
medyagh
requested changes
Apr 20, 2021
There was a problem hiding this comment.
also change UI to be more easy to see
maybe use the Red Box ui helper we have
❌ Exiting due to GUEST_START: wait 6m0s for node: waiting for apps_running: expected k8s-apps: missing components: kube-dns
----------------- Red Box thing ---------------------------------
😿 If the above advice does not help, please let us know by filing an issue
👉 https://github.com/kubernetes/minikube/issues/new/choose
and provide the following information in the issue
- /Users/powellsteven/.minikube/logs/lastStart.txt
- - minikube logs
-----------------------------------------------------------------
|
please update the UI in the PR description whenever new UI ready |
medyagh
requested changes
Apr 22, 2021
spowelljr
force-pushed
the
addLogFileToGithubIssue
branch
from
10c378e
to
a669ebb
Compare
medyagh
approved these changes
Apr 24, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
medyagh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9398
Adds a line to the output when we tell the user to create a GitHub issue. The line contains the path of the latest log file to be attached to the GitHub issue to aid in debugging the issue.
Tested on Mac and Linux so far, will test on Windows as well.
Before
After