-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon: bump csi-hostpath-driver to v1.6.0 #10798
Conversation
Hi @govargo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
/assign @tstromberg |
/ok-to-test |
kvm2 Driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please ensure to fix the test
https://storage.googleapis.com/minikube-builds/logs/10798/3aa47d5/Docker_Linux.html#fail_TestAddons%2fparallel%2fCSI
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: govargo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@medyagh I'll check the result of |
kvm2 Driver Times for Minikube (PR 10798): 64.3s 65.2s 66.9s Averages Time Per Log
docker Driver Times for Minikube (PR 10798): 28.0s 27.4s 26.4s Averages Time Per Log
|
… the error, because this CR is deleted befor deleting volumesnapshotclass CRD
/retest-this-please |
What type of PR is this?
/area addons
What this PR does / why we need it:
This PR upgrades the csi-hostpath-driver addon to v1.6.0(latest).
And this PR make
volumesnapshots
addon contain the volumesnapshotclasscsi-hostpath-snapclass
.Before this PR, the users have to register the volumesnapshotclass manually.
After this PR, however, user don't have to register the volumesnapshotclass by only enabling addon
volumesnapshots
.I also update the turtorial for CSI Driver and Volume Snapshots.
Which issue(s) this PR fixes:
Fix #10797
Does this PR introduce a user-facing change?
Yes, this PR change VolumeSnaphost API version(v1).
Before this PR
After this PR
Entire docker images of the addon are upgraded.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: