Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon: bump csi-hostpath-driver to v1.6.0 #10798

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Addon: bump csi-hostpath-driver to v1.6.0 #10798

merged 2 commits into from
Mar 23, 2021

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Mar 12, 2021

What type of PR is this?

/area addons

What this PR does / why we need it:

This PR upgrades the csi-hostpath-driver addon to v1.6.0(latest).
And this PR make volumesnapshots addon contain the volumesnapshotclass csi-hostpath-snapclass.
Before this PR, the users have to register the volumesnapshotclass manually.
After this PR, however, user don't have to register the volumesnapshotclass by only enabling addon volumesnapshots.
I also update the turtorial for CSI Driver and Volume Snapshots.

Which issue(s) this PR fixes:

Fix #10797

Does this PR introduce a user-facing change?

Yes, this PR change VolumeSnaphost API version(v1).

Before this PR

% ./out/minikube addons enable csi-hostpath-driver
...
    ▪ Using image quay.io/k8scsi/csi-attacher:v3.0.0-rc1
    ▪ Using image quay.io/k8scsi/csi-node-driver-registrar:v1.3.0
    ▪ Using image quay.io/k8scsi/hostpathplugin:v1.4.0-rc2
    ▪ Using image quay.io/k8scsi/livenessprobe:v1.1.0
    ▪ Using image quay.io/k8scsi/csi-resizer:v0.6.0-rc1
    ▪ Using image quay.io/k8scsi/csi-snapshotter:v2.1.0
    ▪ Using image gcr.io/k8s-staging-sig-storage/csi-provisioner:v2.0.0-rc2
% ./out/minikube addons enable volumesnapshots
// Users have to register the volumesnapshotclass manually
% kubectl get volumesnapshotclasses
No resources found

After this PR

Entire docker images of the addon are upgraded.

% ./out/minikube addons enable csi-hostpath-driver
...
    ▪ Using image k8s.gcr.io/sig-storage/csi-attacher:v3.1.0
    ▪ Using image k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.0.1
    ▪ Using image k8s.gcr.io/sig-storage/livenessprobe:v2.2.0
    ▪ Using image k8s.gcr.io/sig-storage/csi-resizer:v1.1.0
    ▪ Using image k8s.gcr.io/sig-storage/csi-external-health-monitor-agent:v0.2.0
    ▪ Using image k8s.gcr.io/sig-storage/csi-external-health-monitor-controller:v0.2.0
    ▪ Using image k8s.gcr.io/sig-storage/hostpathplugin:v1.6.0
    ▪ Using image k8s.gcr.io/sig-storage/csi-snapshotter:v4.0.0
    ▪ Using image k8s.gcr.io/sig-storage/csi-provisioner:v2.1.0
% ./out/minikube addons enable volumesnapshots
// Volumesnapshotclass is registered automatically
% kubectl get volumesnapshotclasses
NAME                     DRIVER                DELETIONPOLICY   AGE
csi-hostpath-snapclass   hostpath.csi.k8s.io   Delete           10s

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 12, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 12, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@govargo
Copy link
Contributor Author

govargo commented Mar 12, 2021

/assign @tstromberg

@govargo govargo changed the title Upgrade csi-hostpath addon to v1.6.0 Upgrade csi-hostpath-driver addon to v1.6.0 Mar 12, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2021
@medyagh
Copy link
Member

medyagh commented Mar 12, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10798): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10798/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10798/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10798): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10798/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10798/minikube: exec format error

@medyagh
Copy link
Member

medyagh commented Mar 12, 2021

@medyagh medyagh self-requested a review March 12, 2021 20:44
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: govargo
To complete the pull request process, please ask for approval from tstromberg after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2021
@govargo
Copy link
Contributor Author

govargo commented Mar 15, 2021

@medyagh
Thank you for your point out, medya.
I fixed this error of disabling volumesnapshots addons.

I'll check the result of CSI test on Docker again.

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 64.0s 65.9s 65.6s
Average time for minikube: 65.2s

Times for Minikube (PR 10798): 64.3s 65.2s 66.9s
Average time for Minikube (PR 10798): 65.5s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10798) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 40.2s    | 39.8s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 9.0s     | 2.0s                |
| on Docker 20.10.3 ...                      |          |                     |
|   - Generating certificates                | 2.8s     | 5.0s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 10.2s    | 15.1s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.0s     | 1.4s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.3s     | 1.3s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.4s     | 0.7s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 28.9s 27.8s 27.2s
Average time for minikube: 28.0s

Times for Minikube (PR 10798): 28.0s 27.4s 26.4s
Average time for Minikube (PR 10798): 27.3s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10798) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 10.4s    | 10.2s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.6s    | 15.3s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.4s     | 1.3s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

@govargo
Copy link
Contributor Author

govargo commented Mar 16, 2021

… the error, because this CR is deleted befor deleting volumesnapshotclass CRD
@medyagh
Copy link
Member

medyagh commented Mar 23, 2021

/retest-this-please

@medyagh medyagh merged commit 38ed70a into kubernetes:master Mar 23, 2021
@medyagh medyagh changed the title Upgrade csi-hostpath-driver addon to v1.6.0 Addon: Upgrade csi-hostpath-driver to v1.6.0 Mar 23, 2021
@medyagh medyagh changed the title Addon: Upgrade csi-hostpath-driver to v1.6.0 Addon: bump csi-hostpath-driver to v1.6.0 Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade csi-hostpath-driver addon to v1.6.0
6 participants