Make sure to show debian warning also for cgroup 2 #10468
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
afbjorklund
force-pushed
the
cgroups-warning
branch
from
2690c0b
to
3992970
Compare
Move check to function, to cut down on complexity
afbjorklund
force-pushed
the
cgroups-warning
branch
from
3992970
to
2c87f6e
Compare
| // requires CONFIG_MEMCG_SWAP_ENABLED or cgroup_enable=memory in grub | ||
| klog.Warning("Your kernel does not support swap limit capabilities or the cgroup is not mounted.") | ||
| memcgSwap = false | ||
| } |
There was a problem hiding this comment.
one internal user told me they can not apply the memory limit either (I have logs in an issue)
I think we should skip the Memory limit too if this file doesnt exists
cat /sys/fs/cgroup/memory/memory.limit_in_bytes
There was a problem hiding this comment.
Added as PR #10507
There was a problem hiding this comment.
that one only checks for
if _, err := os.Stat("/sys/fs/cgroup/memory/memsw.limit_in_bytes");
we need to check for cat /sys/fs/cgroup/memory/memory.limit_in_bytes
to not add memory limits ( I will add a PR for that)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://docs.docker.com/engine/install/linux-postinstall/#your-kernel-does-not-support-cgroup-swap-limit-capabilities
Closes #10371