Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new driver "SSH" to bootstrap generic minkube clusters over ssh #10099

Merged
merged 32 commits into from
Jan 19, 2021

Commits on Jan 6, 2021

  1. Add minikube support for the "generic" VM driver

    This driver connects to an already existing virtual machine,
    using the provided IP address and SSH user/key/port parameters.
    
    On this machine, libmachine will provision the docker daemon
    and minikube will bootstrap the kubernetes cluster (as usual).
    afbjorklund committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    0076335 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c076669 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7c5ba62 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2b5c5b9 View commit details
    Browse the repository at this point in the history
  5. Don't try to start/stop drivers without VMs

    It is not supported anyway, and just throws errors.
    There is no use to restart or to retry, just give up.
    
    This should never be a problem with "none", though.
    That always return running, while generic tests ssh.
    afbjorklund committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    6dad258 View commit details
    Browse the repository at this point in the history
  6. Allow actually using the generic driver

    All drivers *must* be in "supportedDrivers"
    
    Delete Podman on Darwin (Mac), not available
    afbjorklund committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    d0260cc View commit details
    Browse the repository at this point in the history
  7. Call DetectProvisioner for the generic driver

    It was failing to install the "docker" package
    
    Since the provisioning was defaulting to ISO
    afbjorklund committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    d3ea174 View commit details
    Browse the repository at this point in the history
  8. Fix failing unit test for MachineType

    Since we don't know the remote machine type anyway,
    it could be a virtual machine or a physical server.
    
    But we don't add any _extra_ isolation for minikube,
    so go with "bare metal machine" machine type for now.
    afbjorklund committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    c3a23cd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d96d3be View commit details
    Browse the repository at this point in the history
  10. Need to set up docker group in start - not in fix

    It was only called for existing machines, not for new.
    
    But other commands expect to be able to run "docker".
    afbjorklund committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    a0d2c1a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a3b3b55 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fa05fcd View commit details
    Browse the repository at this point in the history
  13. Use CommonDrivers and drop machine GetCreateFlags

    This makes the machine driver specific to minikube
    afbjorklund committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    a77e3de View commit details
    Browse the repository at this point in the history
  14. Change meaning of Stop/Start/Restart to minikube

    The "none" driver has redefined stop and start to mean the
    kubelet rather than the host itself. Use the same API here.
    
    Killing actual containers remotely remains to be implemented.
    Only stop the kubelet service for now, and assuming systemd.
    afbjorklund committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    a120c54 View commit details
    Browse the repository at this point in the history
  15. Move the constants for flag defaults from drivers

    Not using the default libmachine drivers anymore
    afbjorklund committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    72a0fd6 View commit details
    Browse the repository at this point in the history
  16. Also remove unused machine SetConfigFromFlags

    Setting the config directly instead in minikube
    afbjorklund committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    1d6c86c View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    1d5ee9e View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Configuration menu
    Copy the full SHA
    7498432 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3921836 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d51443b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    010e5fb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e4ebaea View commit details
    Browse the repository at this point in the history
  6. Add placeholder for docs for the generic driver

    But most of it is identical to the "none" driver
    afbjorklund committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    fb6cf6b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    40ec0e8 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2021

  1. Configuration menu
    Copy the full SHA
    e53f537 View commit details
    Browse the repository at this point in the history
  2. Rename the generic driver to the ssh driver

    Now that we have forked the machine driver
    afbjorklund committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    b2121ea View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. Configuration menu
    Copy the full SHA
    1663a03 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    529d2c3 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. Configuration menu
    Copy the full SHA
    abb556f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    099c6b7 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2021

  1. Configuration menu
    Copy the full SHA
    4611e2f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    541193c View commit details
    Browse the repository at this point in the history