Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube scp #9930

Closed
bl-ue opened this issue Dec 11, 2020 · 12 comments · Fixed by #10198
Closed

minikube scp #9930

bl-ue opened this issue Dec 11, 2020 · 12 comments · Fixed by #10198
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@bl-ue
Copy link

bl-ue commented Dec 11, 2020

It would be nice to be able to have minikube scp like minikube ssh, to copy files in the the minikube node. An use case would be: copying Dockerfiles to the node to build custom docker images for Kubernetes.

In the meantime, for all of you that want this feature, here's a workaround:

scp -i $(minikube ssh-key) <file> docker@$(minikube ip):

edit: you can also use minikube docker-env to set up the docker client to point to minikube's docker daemon, and build the image locally. However, this still doesn't work for copying files...

@afbjorklund
Copy link
Collaborator

This feature is available in docker-machine, so we should probably make it available in minikube as well.

https://docs.docker.com/machine/reference/scp/

@afbjorklund afbjorklund added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 11, 2020
@afbjorklund
Copy link
Collaborator

The turbo-charged version also has support for rsync, for delta transfer and other advanced uses.

@afbjorklund
Copy link
Collaborator

An use case would be: copying Dockerfiles to the node to build custom docker images for Kubernetes.

Like you mention, this use case should be supported by minikube (or docker) directly... See also #4868

@arjunagl
Copy link

I would like to work on this if there is no objection.

@afbjorklund
Copy link
Collaborator

Sure, please do a PR.

The original code is in: https://github.com/docker/machine/blob/master/commands/scp.go

But minikube is different...

It would be OK to call out to the external programs for "scp" and for "rsync", at least initially.

@tstromberg tstromberg added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Dec 14, 2020
@tstromberg
Copy link
Contributor

I too would love to see this get implemented.

@arjunagl
Copy link

/assign

@anencore94
Copy link
Contributor

Is there any progress on this issue? @arjunagl
If you are unavailable to take this issue because of other schedule, I would love to take this!

@arjunagl
Copy link

@anencore94 please go ahead. I got a bit stuck with some other stuff.

@arjunagl
Copy link

/unassign

@anencore94
Copy link
Contributor

Thanks for your answer @arjunagl :)
/assign

@bl-ue
Copy link
Author

bl-ue commented Mar 23, 2021

🎊 🎉 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants