Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile list for multi node shows error wrongfully #9772

Closed
medyagh opened this issue Nov 24, 2020 · 4 comments · Fixed by #9996
Closed

profile list for multi node shows error wrongfully #9772

medyagh opened this issue Nov 24, 2020 · 4 comments · Fixed by #9996
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Nov 24, 2020

as noted by @sharifelgamal the missing part of this PR is left #9702 (comment)


|----------|-----------|---------|--------------|------|---------|---------|-------|
| Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes |
|----------|-----------|---------|--------------|------|---------|---------|-------|
| minikube | docker    | docker  | 192.168.49.2 | 8443 | v1.19.4 | Running |     1 |
| p2       | docker    | docker  | 192.168.59.2 | 8443 | v1.19.4 | Running |     2 |
|----------|-----------|---------|--------------|------|---------|---------|-------|
❗  Found 1 invalid profile(s) ! 
	 p2-m02
💡  You can delete them using the following command(s): 
	 $ minikube delete -p p2-m02 
@medyagh medyagh added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 24, 2020
@daehyeok
Copy link
Contributor

Do we have any reason check both of directory and container in the ListProfiles func?

func ListProfiles(miniHome ...string) (validPs []*Profile, inValidPs []*Profile, err error) {

Is it added to remove all nodes when run delete profile command(58b637b)? It looks nodes and profiles are not distinguished in the function. (E.g. seconds node p2-m02 also returned as invalid 'profile' by ListProfiles func).

Currently, returned invalidProfiles used only for List, Delete, Valid profile. I'm not sure if i remove sub node(profile) from ListProfiles's result(but also change Delete profile function to keep handling multiple nodes), It will have potential problems or not.

@medyagh
Copy link
Member Author

medyagh commented Dec 11, 2020

one reason I am thinking is in the clean up process, when there is no minikube config,
we use the existing Directory as Possible left over minikubes so we use that delete minikube left over containers

@medyagh
Copy link
Member Author

medyagh commented Dec 11, 2020

so imagine u create minikube with docker
then u delete minikube home (config) now the containers are still there ... but we wanna clean up the minikube if someone says "minikube delete --all"
https://github.com/medyagh/minikube/blob/0a5ef42ed548d65694b6d96b487fbe0bf8b3db01/pkg/minikube/machine/delete.go#L39

@daehyeok
Copy link
Contributor

Is it anyway to check node is part of multnode cluster or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants