Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stauts: avoid logging error "kubeconfig endpoint" when cluster is "starting" ... #9457

Closed
medyagh opened this issue Oct 13, 2020 · 1 comment · Fixed by #10968
Closed

stauts: avoid logging error "kubeconfig endpoint" when cluster is "starting" ... #9457

medyagh opened this issue Oct 13, 2020 · 1 comment · Fixed by #10968
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@medyagh
Copy link
Member

medyagh commented Oct 13, 2020

while my cluster was Starting... I go this error
minikube should not error while it is in starting tage

medya@~/workspace/minikube (stopped_kubelet) $ ./out/minikube  status
E1012 19:31:27.358199   69479 status.go:364] kubeconfig endpoint: extract IP: "minikube" does not appear in /Users/medya/.kube/config
minikube
type: Control Plane
host: Running
kubelet: Stopped
apiserver: Stopped
kubeconfig: Misconfigured


WARNING: Your kubectl is pointing to stale minikube-vm.
To fix the kubectl context, run `minikube update-context`
minikube-m02
type: Worker
host: Stopped
kubelet: Stopped
@medyagh medyagh changed the title stauts: avoid error when cluster is "starting" stauts: avoid logging error for nip IP when cluster is "starting" Oct 13, 2020
@medyagh medyagh changed the title stauts: avoid logging error for nip IP when cluster is "starting" stauts: avoid logging error "kubeconfig endpoint" when cluster is "starting" ... Oct 13, 2020
@medyagh medyagh added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Oct 14, 2020
@tstromberg tstromberg added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 14, 2020
@medyagh medyagh added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Feb 18, 2021
@MadhavJivrajani
Copy link
Contributor

MadhavJivrajani commented Mar 19, 2021

/assign

Hey, I'd like to take this up if that's okay, here's what I was thinking of changing here:

if err != nil {
klog.Errorf("kubeconfig endpoint: %v", err)
st.Kubeconfig = Misconfigured
}
}

if err != nil && st.Host != state.Starting.String() {
		klog.Errorf("kubeconfig endpoint: %v", err)
		st.Kubeconfig = Misconfigured
}

Does that sound okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants