$TMPDIR fills with log files - change logging to create less inodes (add retention) #9156
Comments
|
/triage support |
k8s-ci-robot
added
the
kind/support
tstromberg
changed the title
tstromberg
added
kind/cleanup
tstromberg
changed the title
|
I'm bumping up the priority on this, as apparently caused some issues with users that use 3rd party software that calls I looked into this some, and it seems that this behavior can't be changed with the current logging library in use: https://godoc.org/github.com/golang/glog I attempted to migrate minikube to klog last year, but didn't seal the deal: #5318 My preferred approach would be to set the logging destination to something that naturally cleans up after itself, for instance, using a hash of ARGV: |
|
My $TMPDIR was also filling up with minikube log files which led me to this issue. I was finding around 30 new "minikube" log files per minute in my temp folder: filename example: file content example: At first, naturally, I blamed minikube seeing as each log file name started with "minikube.exe". However that blame was misplaced as I subsequently traced the creation of these files to third party software. It was Google's Cloud Code extension installed in my Visual Studio Code editor that was the process actually creating these logs and doesn't identify itself in the logs. Once I removed the extension then these log files immediately stopped being generated. Link: So problems with 3rd party software and minikube. |
|
/assign |
|
thank you @JohnCarmichael3000 for the details, we will be moving to klog that will have a better experience with logs files |
|
we need to ensure our customers are using --log_dir="" |
|
we also need to verify --log_dir is working, |
medyagh
changed the title
medyagh
changed the title
|
todo: investigate whether it's possible to use log append mode with klog to reuse the existing log file |
|
@limberger do u mind checking the latest version of minikube ? we fixed the -log_dir flag, that would help with fixing this issue |
|
I stoped to use minikube in the environment where this issue was ocurring. I can't check if is fixed! In my minikube on my fisical machine this issue never happened! |
|
we fixed --log_dir flag, so if u specify an empty log dir it will not create temp files, however u are right by default minikube should not create multiple temp files... this shoiuld be fixed |
|
cc @spowelljr |
|
/assign @bharathkkb |
|
@medyagh: GitHub didn't allow me to assign the following users: bharathkkb. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign bharathkkb |
|
@bharathkkb are u still working on this ? any updates? |
|
Hi @medyagh
without
IIUC the ask is to prevent the new files being created for each binary command and continue to append to the initially created set of logfiles? |
|
@bharathkkb i think that
if all logs should be appended to a single file, we've implemented example: also, you can use something like: |
Steps to reproduce the issue:
minikube startafter some time (less than 24 hours):
after some minutes:
Sample:
Full output of
minikube startcommand used, if not already included:Optional: Full output of
minikube logscommand:The text was updated successfully, but these errors were encountered: