Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--extra-config with double quotes breaks kubeadm init #8694

Closed
medyagh opened this issue Jul 10, 2020 · 7 comments · Fixed by #10886
Closed

--extra-config with double quotes breaks kubeadm init #8694

medyagh opened this issue Jul 10, 2020 · 7 comments · Fixed by #10886
Assignees
@vishjain
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Jul 10, 2020 •
edited
Loading

we should validate options like this

./out/minikube start --driver=docker --extra-config=etcd.client-cert-auth=false”

currently running that will make minikube kubeadm hang.
@medyagh medyagh changed the title validate --extra-config validate --extra-config for double quotes Jul 10, 2020
@medyagh medyagh added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 10, 2020
@medyagh medyagh changed the title validate --extra-config for double quotes --extra-config with double quotes breaks minikube kubeadm init Jul 10, 2020
@medyagh medyagh changed the title --extra-config with double quotes breaks minikube kubeadm init --extra-config with double quotes breaks kubeadm init Jul 10, 2020
@medyagh medyagh added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jul 10, 2020
@vinu2003
Copy link
Contributor

Hey @medyagh I can help with this.
/assign @vinu2003

@medyagh
Copy link
Member Author

medyagh commented Jul 11, 2020

@vinu2003 it's yours !

@vinu2003
Copy link
Contributor

Reproduced this issue. started working on PR.

@RA489
Copy link

RA489 commented Nov 19, 2020

@vinu2003 Are you still working on this issue?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2021
@vishjain vishjain removed their assignment Feb 17, 2021
@medyagh medyagh added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. labels Feb 18, 2021
@medyagh
Copy link
Member Author

medyagh commented Feb 18, 2021

@vinu2003 I haven't heard any updates, this issue is available for anyone who likes to pick it up

@medyagh medyagh removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2021
@vishjain
Copy link
Contributor

/assign

@vishjain vishjain mentioned this issue Mar 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishjain vishjain

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve validation for extra-config. vishjain/minikube
6 participants
@medyagh @vishjain @k8s-ci-robot @fejta-bot @vinu2003 @RA489